Inviting an existing member to a workspace on NewDot uses the OldDot invite template

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #38023

Action Performed:

1. Go to workspace settings
2. Click on 'Members'
3. Choose a contact that has an existing Expensify account (and that you have access to an email inbox for)
4. Invite the existing account to the workspace
5. Go to the email inbox of that account

Expected Result:

1. Don't send the OldDot template when inviting existing accounts to a workspace on NewDot
2. Send the welcomeNote in the workspace chat with the email fallback using the same custom subject header as for a newly invited account:

Subject: [First Name] [Last Name] ([[email protected]]) invited you to [workspaceName]
Body:

Actual Result:

The OldDot template for inviting an existing account is used instead

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bf2f17a3669228c7
• Upwork Job ID: 1785359952219054080
• Last Price Increase: 2024-05-01

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[rayane-djouah]

@Gonals could you please take a look at this as per #38023 (comment)? Thank you!

[mallenexpensify]

Good 👀 @rayane-djouah , thanks for tagging and linking. Awaiting feedback from @Gonals

[danielrvidal]

Hey @lanitochka17 I'm a bit unsure of what you were expecting in that box? Do you mind outlining a bit more information on what you think the issue is. I don't think we changes the contents of the welcomeNote, we just changed the notification/email that we send once it's done.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[lanitochka17]

@danielrvidal Hey, according to PR #38023
and step 4: Verify that: Welcome message has a new format.
In the video in Pr is displayed in a new format.

[mallenexpensify]

Pinged @Gonals in NewDot for 👀 on this and the PR

[melvin-bot]

@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

@Gonals gonna assign you to help catch your 👀
Added Needs Reproduction cuz I don't want to add to a project til I know what's up.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bf2f17a3669228c7

[melvin-bot]

@mallenexpensify @c3024 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@mallenexpensify, @c3024 Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Waiting for internal pickup. We have site issues and deploy freeze, I'll revisit next week.

[melvin-bot]

@mallenexpensify, @c3024 Huh... This is 4 days overdue. Who can take care of this?

[mallenexpensify]

Posted in #wave-collect and cross posted in #engineering to try to get a volunteer
https://expensify.slack.com/archives/C036QM0SLJK/p1715735812026129
https://expensify.slack.com/archives/C03SSAQ7P/p1715735821061659

[mallenexpensify]

@Gonals back in a few days

[melvin-bot]

@mallenexpensify, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Waiting for @Gonals return

[Gonals]

I'm back!

[Gonals]

@mallenexpensify, @trjExpensify, if I'm understanding this correctly, we basically want the same message to be sent for existing accounts and for new accounts, right?

[trjExpensify]

if I'm understanding this correctly, we basically want the same message to be sent for existing accounts and for new accounts, right?

Yep, that's correct. We want to use the same message for existing and new accounts invited to workspaces in NewDot. 👍

[melvin-bot]

@Gonals, @mallenexpensify, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Gonals]

Not overdue. In fact, this should be fixed. Closing