CRITICAL: [Actionable Whispers] Track scan expense is duplicated when it is submitted to someone

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #38709

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Track expense
3. Create a track scan expense
4. From the whisper, select Submit it to someone
5. Select a user to submit to
6. In 1:1 DM with the user from Step 5, click on the expense preview
7. Click on the header subtitle to return to main chat
8. Click on the same chat in LHN

Expected Result:

he track scan expense will not be duplicated

Actual Result:

The track scan expense is duplicated when it is submitted to someone

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453775_1713454164236.bandicam_2024-04-18_23-24-56-667.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a279eb4ea7ee1906
• Upwork Job ID: 1781106389210488832
• Last Price Increase: 2024-04-18

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@cead22 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[thienlnam]

Doesn't look like it needs to be a blocker, but it looks like the main issue is that we're not using the passed reportActionID in the BE for the moneyRequestPreviewAction

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a279eb4ea7ee1906

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[dangrous]

Notes from DM with @thienlnam

Inside the money request report, there should be IOU reportActions (which we've renamed to MoneyRequestPreviews).

And then when you click on that, you are taken to the money request reportIn the DM, there should be a REPORTPREVIEW reportAction added or updated

But basically I think what needs to happen is we need to start accepting a new parameter in the BE called report reportPreviewReportActionID, and ensure that we use that reportID for the REPORTPREVIEW reportAction

[quinthar]

What's the next step here -- is @thienlnam taking this, or @dangrous ?

[thienlnam]

I'm still taking this since @dangrous will be out this week

[thienlnam]

Done! Changes are live