Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit Expense - PDF files can not be added to scan expense on mobile apps #40486

Closed
4 of 6 tasks
kbecciv opened this issue Apr 18, 2024 · 7 comments
Closed
4 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Apr 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #36314
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch new expensify
  2. Tap on the fab button and Submit Expense
  3. Tap on Scan tab
  4. Tap on image icon and Choose document
  5. Add a PDF file

Expected Result:

The PDF file can be added to the scan receipt and the next part of the flow appears without issues

Actual Result:

An error message appears blocking the user from adding a PDF file for scanning

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453574_1713443618776.RPReplay_Final1713443301.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Krishna2323
Copy link
Contributor

This is fixed in this PR.

@blimpich
Copy link
Contributor

Not a blocker, since its likely already fixed by a PR that hasn't been deployed to staging yet, and is also not a huge bug.

I will retest this once #40351 has been deployed to staging and confirm that it is fixed.

@blimpich blimpich added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Apr 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@blimpich
Copy link
Contributor

Not overdue, still waiting for that PR to be deployed to staging and ideally production before retesting this and closing.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 22, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

@blimpich Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@blimpich
Copy link
Contributor

Is fixed in staging now, just tested.

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants