[$250] IOU - Unable to change currency in transaction thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-13
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #40605

Action Performed:

1. Go to staging.new.expensify.com
2. Go to 1:1 DM
3. Create a manual request
4. Go to transaction thread
5. Click Amount
6. Click Currency
7. Change the currency

Expected Result:

The currency is changed

Actual Result:

The currency is not changed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6455838_1713622330282.bandicam_2024-04-20_22-11-14-662.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f76111d172d99485
• Upwork Job ID: 1781769508041547776
• Last Price Increase: 2024-04-20
• Automatic offers:
• DylanDylann | Reviewer | 0
• ikevin127 | Contributor | 0

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mountiny]

Taking this over and making it external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f76111d172d99485

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[mountiny]

Looking for proposals

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Unable to change currency in transaction thread

What is the root cause of that problem?

It is regression from this PR.
When we update currency we set it in draft transaction here. But here in amount screen we get it from backup transaction

What changes do you think we should make in order to solve the problem?

1. Update TRANSACTION_BACKUP to TRANSACTION_DRAFT . Also change the backupTransaction prop name to draftTransaction

2. Use draftTransaction instead backupTransaction

3. Do obe of below options
   Option 1 Update draft transaction based original transaction before going to transaction tread
   Option 2 Update this condition like below .

const {currency: originalCurrency} = ReportUtils.getTransactionDetails(isEditing && !draftTransaction ? transaction : draftTransaction ) ?? {currency: CONST.CURRENCY.USD};

Option 3 Here currency is expected in route params but we never send it because there is not ability to send it in routes. Add ability to receive currency and send it from here.

getRoute: (action: IOUAction, iouType: IOUType, transactionID: string, reportID: string, currency = '', backTo = '') =>
    getUrlWithBackToParam(`${action as string}/${iouType as string}/amount/${transactionID}/${reportID}?currency=${currency}`, backTo),

The purpose of step 3 is a fixing #40543

What alternative solutions did you explore?

[mountiny]

Can you please also point to the regression PR? thank you

[shahinyan11]

Can you please also point to the regression PR? thank you

#40605

[mountiny]

Assigning @allroundexperts as c+ here because of the regression

@shahinyan11 Can you please raise the PR with a fix? thanks!

[shahinyan11]

@mountiny Just one clarification, should I implement my main solution?

[ikevin127]

@mountiny Payment is due today on this issue based on #40631 (comment).

Can you please assign somebody from Bug to handle this today ? Thank you!

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mallenexpensify]

@mountiny can you help here with the payment breakdown?

@shahinyan11 paid $125 via Upwork
@ikevin127 paid $250 via Upwork
@DylanDylann paid $250 via Upwork

[shahinyan11]

@mallenexpensify I have apllied to the job

[mallenexpensify]

@mountiny is back on Monday, gonna pause here til then.

[melvin-bot]

@mallenexpensify, @mountiny, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mallenexpensify, @mountiny, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?

[mountiny]

@mallenexpensify I believe that breakdown is good

[melvin-bot]

📣 @ShaheFS! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[shahinyan11]

@mallenexpensify I applied but you didn't accept

[mallenexpensify]

Correct @shahinyan11 , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01f76111d172d99485

[shahinyan11]

Correct @shahinyan11 , can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01f76111d172d99485

@mallenexpensify I have accepted

[mallenexpensify]

Everyone paid, payment comment updated above. Do we neee a TestRail GH here? Looked above but wasn't sure cuz it looks like this was a regression, so the TR for the other issue should have have a TR to cover this, right?

[mallenexpensify]

Since this came from a regression I don't think we need a new TestCase, comment/reopen if you disagree.