[HOLD for payment 2024-06-03] [$250] Group chat - App redirects to Concierge chat when leaving group chat and room

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.67-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Visit a few reports.
3. Go to FAB > Start chat.
4. Create a group chat.
5. Click on the chat header.
6. Click Leave.

Expected Result:

• When a user leaves a room/group, we should navigate them to their last opened report
• If it's a new user who opens the link from incognito mode and then leaves the room, they will be directed to the concierge

Actual Result:

• User is always redirected to Concierge chat, the same issue happens when leaving the room
  • On Android app, it redirects to the previous report, but it opens Concierge chat when tapping back button on the previous report.
  • On iOS app, it returns to group details page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6463513_1714196912223.group_leave_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01de0c9a8aaa7e6078
• Upwork Job ID: 1784843922902315008
• Last Price Increase: 2024-04-29
• Automatic offers:
• ahmedGaber93 | Reviewer | 0
• Nodebrute | Contributor | 0

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@dylanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

Recording.2405.mp4

[Julesssss]

Not critical enough to block deploy. Opening up to contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01de0c9a8aaa7e6078

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[Julesssss]

Shared with C+ team here.

[Julesssss]

After reviewing all the merged PRs, these 3 seem like the only possible causes:

• Fix LHN breaking when leaving deep linked room #40701
• perf: make switch between chat list and workspaces smoother #36420
• fix: Missing 'Leave Thread' Button Offline in Self DM Thread #39993 ❌

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dylanexpensify]

@Nodebrute @ahmedGaber93 can we get an update and eta on getting this mrged?

[ahmedGaber93]

@dylanexpensify I reviewed the PR yesterday and left some comments, and I am waiting @Nodebrute response

[Nodebrute]

@dylanexpensify I'm currently working on it.

[dylanexpensify]

Sounds great!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix navigation to concierge after leaving the group #42020

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Reviewer)
• @Nodebrute requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93] Determine if we should create a regression test for this bug.
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

upcoming!

[dylanexpensify]

Payment coming today!

[Nodebrute]

@dylanexpensify bump for payments

[Julesssss]

Only overdue for payment. Commenting to remove the label and I'll bump Dylan in Slack.

[dylanexpensify]

Apologies, paid!