Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting checklist] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN #40680

Closed
5 of 6 tasks
izarutskaya opened this issue Apr 22, 2024 · 36 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Apr 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.62.17
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR: https://github.com/Expensify/Expensify/issues/318139
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/r/8813851443373010
  2. Log in with a new Gmail account
  3. Leave the room

Or

  1. Have a room on some policy
  2. Join that room
  3. in new tab, deeplink to that room
  4. Leave it

Expected Result:

LHN should still be visible.

Actual Result:

LHN disappears upon leaving a public room. It returns if the page is refreshed.
On mWeb, iOS and Android you're unable to use the "<" button to go to the LHN from Concierge after leaving the room.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6456699_1713723474319.LHN.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c4dd40ad35562892
  • Upwork Job ID: 1782375600407408640
  • Last Price Increase: 2024-04-22
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 22, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@twisterdotcom I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #cvip-vsb.

@izarutskaya
Copy link
Author

Production

bandicam.2024-04-22.14-40-01-789.mp4

@twisterdotcom
Copy link
Contributor

twisterdotcom commented Apr 22, 2024

Okay, I recreated this here:

40680.mp4

But I have since recreated it on staging with my normal account, doesn't have to be new, or only have 1 other chat in the LHN. Simply put, leaving a room is broken on staging. It removes the LHN AFAIK if the room is left just after joining.

Agree this is a deploy blocker.

@twisterdotcom
Copy link
Contributor

I have no idea why though cc @Beamanator. Maybe this one from @MonilBhavsar? #35671.

Maybe something to do with leaving groups cc @marcaaron?

@twisterdotcom
Copy link
Contributor

Going to make it External to see if we can get a quick fix and some C+ eyes anyway.

@twisterdotcom twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Apr 22, 2024
@melvin-bot melvin-bot bot changed the title LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01c4dd40ad35562892

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@twisterdotcom
Copy link
Contributor

@cubuspl42 would love your help looking for the offending PR here too. Definitely seems like a regression.

@mountiny
Copy link
Contributor

The reproduction steps are a bit esoteric, we need to go and deeplink to the room in new tab, then it sometimes happens when you leave it sometimes it doesnt for me

@MonilBhavsar
Copy link
Contributor

#35671 doesn't seem like a offending PR

@MonilBhavsar
Copy link
Contributor

The reproduction steps are a bit esoteric

I am able to reproduce consistently with -

  1. Copy the room url
  2. Pasting it and joining the room
  3. Leaving the room 💥

@MonilBhavsar
Copy link
Contributor

Okay, while checking if our PR has caused this, I think I found the issue...

@mallenexpensify
Copy link
Contributor

@Pujan92 reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks
Please review the PR

@Pujan92
Copy link
Contributor

Pujan92 commented Apr 24, 2024

@izarutskaya @twisterdotcom Can you plz recheck on staging whether this issue is still reproducible or not

@twisterdotcom
Copy link
Contributor

Nice! It's fixed!

@MonilBhavsar MonilBhavsar reopened this Apr 25, 2024
@MonilBhavsar MonilBhavsar removed the Reviewing Has a PR in review label Apr 25, 2024
@MonilBhavsar
Copy link
Contributor

I'm able to reproduce this locally with reproduction steps -

  1. As an admin create a workspace
  2. Add two users A and B to the workspace
  3. Login as User A and open policy Expense chat and mention user B and invite them
  4. As a user B, open user's B policy expense chat
  5. Leave the room and 💥

@MonilBhavsar
Copy link
Contributor

@Pujan92 can you please help here by taking a look. My PR seems to fix this issue

@Pujan92
Copy link
Contributor

Pujan92 commented Apr 25, 2024

Sure @MonilBhavsar, I will try to reproduce with the mentioned steps and will check the PR soon.

@MonilBhavsar
Copy link
Contributor

Thanks! Since the root cause is same. May be the original issue is also still reproducible 😄

@Pujan92
Copy link
Contributor

Pujan92 commented Apr 25, 2024

Able to reproduce sometimes and your PR changes make sense to me. Can you plz reopen it?

Screen.Recording.2024-04-25.at.19.56.17.mov

@MonilBhavsar
Copy link
Contributor

Thanks for confirming! Reopened PR

Copy link

melvin-bot bot commented Apr 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 29, 2024
@melvin-bot melvin-bot bot changed the title [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN [HOLD for payment 2024-05-06] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

  • @Pujan92 requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Apr 29, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
  • [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@Pujan92] Determine if we should create a regression test for this bug.
  • [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@Beamanator
Copy link
Contributor

This looks like it's been ready for payment for a bit @twisterdotcom ? :D

@Pujan92
Copy link
Contributor

Pujan92 commented Jun 13, 2024

Bump @twisterdotcom for the payment if we are not considering the issue #41128 as a regression from here.

@twisterdotcom
Copy link
Contributor

#42073 (comment)

@twisterdotcom
Copy link
Contributor

Payment Summary

Upwork Job

@twisterdotcom
Copy link
Contributor

LMK if this needs a regression test.

@twisterdotcom twisterdotcom removed the Awaiting Payment Auto-added when associated PR is deployed to production label Jun 14, 2024
@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-05-06] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN [Awaiting checklist] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN Jun 14, 2024
@Pujan92
Copy link
Contributor

Pujan92 commented Jun 15, 2024

Regression Test Steps

  1. Copy any public room URL and signout
  2. Visit the copied URL and sign in
  3. Leave that public room
  4. Verify the LHN isn't disappear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

8 participants