[C+ Checklist Needs Completion] [$250] Category - First item in the search result is not highlighted when parent category is selected

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4571713
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace has a regular category, parent category and category in Parent: Child format.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go to + > Submit expense > Manual.
4. Proceed to confirmation page.
5. Click Category.
6. Select a regular category.
7. Click Category.
8. Search for the regular category via search field.
9. Note that the first item in the search result is highlighted.
10. Select a parent category (not the child category).
11. Repeat Step 7 to 8.

Expected Result:

When parent category is selected, the first item in the search result will be highlighted when searching for it.

Actual Result:

When parent category is selected, the first item in the search result is not highlighted when searching for it.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6490262_1716536510660.20240524_153607.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f99c23349d15f2f1
• Upwork Job ID: 1795534731844476928
• Last Price Increase: 2024-06-04
• Automatic offers:
• tienifr | Contributor | 102601877

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[cretadn22]

@greg-schroeder Can you assist in providing instructions for creating subcategories?

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When parent category is selected, the first item in the search result is not highlighted when searching for it.

What is the root cause of that problem?

• In here, we do not check whether the item is added to the selectedOptions before. Leads to selectedOptions can be 2.

• Then in here , because flattenedSections.selectedOptions.length !== prevSelectedOptionsLength, so the focused index is set to -1, so the first item in search result is not highlighted.

What changes do you think we should make in order to solve the problem?

• In here we need to check if the item is added to selectedOptions before, if true, do nothing.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f99c23349d15f2f1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[greg-schroeder]

Adding to #wave-collect as this is definitely functionality that came up via the old wave 6

[Ollyws]

@tienifr's proposal LGTM.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lakchote]

@tienifr's proposal LGTM.

[greg-schroeder]

Okay I think you should assign them then, yes? @lakchote

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@Ollyws, @lakchote, @greg-schroeder Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix selected option is not highlighted #43093

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

I think the second deploy + payment date is a red herring ... because the PR was CP'd to staging possibly? Either way I'm going to take the original payment date as the one to focus on here

[greg-schroeder]

Payment summary:

Contributor: @tienifr - $250 - you can make a manual request via ND
C+: @Ollyws - $250 - you can make a manual request via ND

[greg-schroeder]

All that's left is the checklist cc @Ollyws

[tienifr]

Sorry, I actually receive payment via NewDot, I've refunded on Upwork and requested again on NewDot

[greg-schroeder]

Oh, got it, I didn't realize that @tienifr - thanks for doing that. I'll adjust the payment summary. Can you post a screenshot showing the refund on Upwork just for our records when we come back to confirm payment for the manual request? Just to make sure we have our bases covered.

[greg-schroeder]

Oh. You did post a screenshot. I swear it wasn't loading! I am on airplane wifi I blame that. Ignore!

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

#39141

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/39141/files#r1681366877

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes.

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to app
2. Go to + > Submit expense > Manual.
3. Proceed to confirmation page.
4. Click Category.
5. Select a regular category.
6. Click Category.
7. Search for the regular category via search field.
8. Note that the first item in the search result is highlighted.
9. Select a parent category (not the child category).
10. Repeat Step 7 to 8.
11. When parent category is selected, the first item in the search result will be highlighted when searching for it.

Do we agree 👍 or 👎

[Ollyws]

Requested in ND.

[JmillsExpensify]

$250 approved for @Ollyws

[JmillsExpensify]

$250 approved for @tienifr

[greg-schroeder]

filed regression test, closing