fix: Focus not removed when selection list changes. #39141

Krishna2323 · 2024-03-28T02:22:56Z

Details

Fixed Issues

$ #35665
PROPOSAL: #35665 (comment)

Tests

Request money > Enter amount > Focus on any option using down arrow key
Add any participant using split button on user details row
Verify focus is removed

Verify that no errors appear in the JS console

Offline tests

Request money > Enter amount > Focus on any option using down arrow key
Add any participant using split button on user details row
Verify focus is removed

QA Steps

Request money > Enter amount > Focus on any option using down arrow key
Add any participant using split button on user details row
Verify focus is removed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: Krishna Gupta <[email protected]>

melvin-bot · 2024-03-28T02:23:01Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2024-03-28T12:48:32Z

@Krishna2323 please fix all of these:

Krishna2323 · 2024-03-28T17:36:05Z

@situchan, only perf-tests are failing now. What can be the reason?

situchan · 2024-03-28T17:45:59Z

@Krishna2323 please pull main again

Krishna2323 · 2024-03-28T18:39:46Z

@situchan, still not resolved.

situchan · 2024-03-28T18:41:26Z

Looks like it came from this PR as it's related to SelectionList. Please fix

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-03-29T03:45:55Z

@situchan, I'm unable to understand perf failure, do you have any suggestion? The code changes are also quite simple.

situchan · 2024-03-30T02:48:34Z

I also have no idea why this is failing

situchan · 2024-03-30T02:49:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

situchan

Looks good except perf tests failure. Still need to investigate how to fix it.

bondydaa

I'm not sure what to do about the perf tests, I've started a thread here: https://expensify.slack.com/archives/C01GTK53T8Q/p1712085243828569

Signed-off-by: Krishna Gupta <[email protected]>

mountiny · 2024-04-05T11:22:48Z

The performance tests are expected to fail based on this discussion, then the number of the selected options changes, we re-render the list to fix the focus.

This will set a new baseline for the tests, lets keep an eye on any performance bug reports coming from heavy account usage that could be linked to this additional re-render

Krishna2323 · 2024-04-08T11:50:52Z

@bondydaa @mountiny, friendly bump to merge this.

mountiny · 2024-04-08T13:08:42Z

@Krishna2323 can you sync up with main please

Krishna2323 · 2024-04-09T08:59:43Z

@mountiny, sorry I forgot to ping yesterday after syncing, can you pls merge now 🙏🏻

mountiny · 2024-04-09T16:16:56Z

Thanks @Krishna2323! @bondydaa should be on this one today 🙇

bondydaa · 2024-04-09T16:43:59Z

Hmm the test is still failing, if we're okay with the additional re-render don't we need to fix the test to expect 1 instead of 0? otherwise if we merge with this failing won't it fail for everyone going forward?

mountiny · 2024-04-09T18:04:47Z

Hmm the test is still failing, if we're okay with the additional re-render don't we need to fix the test to expect 1 instead of 0? otherwise if we merge with this failing won't it fail for everyone going forward?

We are fine with it and the test is build to merge with main on all branches before running so it should not fail for everyone

bondydaa

ah vit helped clarify how the perf tests work 1:1, merging even with this failing since once we do that the perf tests will automatically get rebuilt and all new PRs will be compared with a re-render of 1 instead of 0. there isn't actually anything to update manually on our end 👍

OSBotify · 2024-04-09T19:05:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-10T17:45:45Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:54:38Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T19:33:51Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-18T04:31:36Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh · 2024-07-16T14:33:50Z

src/components/SelectionList/BaseSelectionList.tsx

-        // Remove the focus if the search input is empty else focus on the first non disabled item
-        const newSelectedIndex = textInputValue === '' ? -1 : 0;
+        // Remove the focus if the search input is empty or selected options length is changed else focus on the first non disabled item
+        const newSelectedIndex = textInputValue === '' || flattenedSections.selectedOptions.length !== prevSelectedOptionsLength ? -1 : 0;


Coming from this issue #36140 (comment), we also need to check all options's length here

Coming from #42583 this was causing the first category search result to not be highlighted.

fix: Focus not removed when selection list changes.

715abef

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 requested a review from a team as a code owner March 28, 2024 02:22

melvin-bot bot removed the request for review from a team March 28, 2024 02:23

melvin-bot bot requested a review from situchan March 28, 2024 02:23

Merge branch 'Expensify:main' into krishna2323/issue/35665

fd23d80

Merge branch 'Expensify:main' into krishna2323/issue/35665

d4e034a

Merge branch 'Expensify:main' into krishna2323/issue/35665

5220450

fix: perf tests.

b91c089

Signed-off-by: Krishna Gupta <[email protected]>

situchan approved these changes Mar 30, 2024

View reviewed changes

melvin-bot bot requested a review from bondydaa March 30, 2024 02:49

Merge branch 'Expensify:main' into krishna2323/issue/35665

9140091

bondydaa previously approved these changes Apr 2, 2024

View reviewed changes

Krishna2323 added 2 commits April 5, 2024 11:44

Merge branch 'Expensify:main' into krishna2323/issue/35665

c295c21

fix: Reassure Performance Tests.

2a3bc3f

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 dismissed bondydaa’s stale review via 2a3bc3f April 5, 2024 06:30

add all deps.

1b876b1

Signed-off-by: Krishna Gupta <[email protected]>

mountiny assigned Krishna2323 Apr 5, 2024

Merge branch 'Expensify:main' into krishna2323/issue/35665

7cb09a2

Merge branch 'Expensify:main' into krishna2323/issue/35665

2fa4845

bondydaa approved these changes Apr 9, 2024

View reviewed changes

bondydaa merged commit 05eb481 into Expensify:main Apr 9, 2024
14 of 15 checks passed

github-actions bot mentioned this pull request Apr 10, 2024

Deploy Checklist: New Expensify 2024-04-10 #40026

Closed

melvin-bot bot mentioned this pull request Apr 18, 2024

[WAITING ON SITU TO FINISH CHECKLIST] [LOW] [Splits] [$500] IOU - Tapping split button & selecting 2nd contact are not highlighted like 1st contact #35665

Closed

6 tasks

hoangzinh mentioned this pull request Jun 19, 2024

[HOLD for payment 2024-07-10] [$500] Workspace switcher - Selection disappears after erasing character with workspace selected #36140

Closed

6 tasks

hoangzinh reviewed Jul 16, 2024

View reviewed changes

Ollyws mentioned this pull request Jul 17, 2024

[C+ Checklist Needs Completion] [$250] Category - First item in the search result is not highlighted when parent category is selected #42583

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Focus not removed when selection list changes. #39141

fix: Focus not removed when selection list changes. #39141

Krishna2323 commented Mar 28, 2024 •

edited

Loading

melvin-bot bot commented Mar 28, 2024

situchan commented Mar 28, 2024

Krishna2323 commented Mar 28, 2024

situchan commented Mar 28, 2024

Krishna2323 commented Mar 28, 2024

situchan commented Mar 28, 2024

Krishna2323 commented Mar 29, 2024

situchan commented Mar 30, 2024

situchan commented Mar 30, 2024

situchan left a comment •

edited

Loading

bondydaa left a comment

mountiny commented Apr 5, 2024

Krishna2323 commented Apr 8, 2024

mountiny commented Apr 8, 2024

Krishna2323 commented Apr 9, 2024

mountiny commented Apr 9, 2024

bondydaa commented Apr 9, 2024

mountiny commented Apr 9, 2024

bondydaa left a comment

OSBotify commented Apr 9, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

hoangzinh Jul 16, 2024

Ollyws Jul 17, 2024

fix: Focus not removed when selection list changes. #39141

fix: Focus not removed when selection list changes. #39141

Conversation

Krishna2323 commented Mar 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 28, 2024

situchan commented Mar 28, 2024

Krishna2323 commented Mar 28, 2024

situchan commented Mar 28, 2024

Krishna2323 commented Mar 28, 2024

situchan commented Mar 28, 2024

Krishna2323 commented Mar 29, 2024

situchan commented Mar 30, 2024

situchan commented Mar 30, 2024

Reviewer Checklist

Screenshots/Videos

situchan left a comment • edited Loading

Choose a reason for hiding this comment

bondydaa left a comment

Choose a reason for hiding this comment

mountiny commented Apr 5, 2024

Krishna2323 commented Apr 8, 2024

mountiny commented Apr 8, 2024

Krishna2323 commented Apr 9, 2024

mountiny commented Apr 9, 2024

bondydaa commented Apr 9, 2024

mountiny commented Apr 9, 2024

bondydaa left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 9, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

hoangzinh Jul 16, 2024

Choose a reason for hiding this comment

Ollyws Jul 17, 2024

Choose a reason for hiding this comment

Krishna2323 commented Mar 28, 2024 •

edited

Loading

situchan left a comment •

edited

Loading