[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$125] Incorrect padding in group invite flow in RHP

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1716499799827299

Action Performed:

1. Create a group
2. Click on the header > members>invite member
3. Observe the padding surrounding the whole thing and the button at the bottom

Expected Result:

There should not be any padding around RHP content and no extra space below the footer button

Actual Result:

There is a padding around the RHP content and extra space below the footer button

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0112cf7031d552a86f
• Upwork Job ID: 1794119738268631040
• Last Price Increase: 2024-05-24
• Automatic offers:
• GandalfGwaihir | Contributor | 102490661

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

extra button margin at the bottom

What is the root cause of that problem?

extra margin at

App/src/pages/InviteReportParticipantsPage.tsx

Line 223 in 8375abe

containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto, styles.mb5]}

What changes do you think we should make in order to solve the problem?

remove the styles.mb5

App/src/pages/InviteReportParticipantsPage.tsx

Line 223 in 8375abe

containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto, styles.mb5]}

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect padding in group invite flow in RHP.

What is the root cause of that problem?

There is extra padding in View which wraps the SelectionList.

App/src/pages/InviteReportParticipantsPage.tsx

Line 202 in 8d73db3

<View style={[styles.flex1, styles.p1]}>

There is extra padding in containerStyles in the FormAlertWithSubmitButton.

App/src/pages/InviteReportParticipantsPage.tsx

Line 223 in 8d73db3

containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto, styles.mb5]}

What changes do you think we should make in order to solve the problem?

styles.mb5 should be removed:

containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto]}

styles.p1 should be removed:

<View style={[styles.flex1]}>
    <SelectionList
        canSelectMultiple
        sections={sections}
        ListItem={InviteMemberListItem}
        textInputLabel={translate('selectionList.nameEmailOrPhoneNumber')}
        textInputValue={searchTerm}
        onChangeText={setSearchTerm}
        headerMessage={headerMessage}
        onSelectRow={toggleOption}
        onConfirm={inviteUsers}
        showScrollIndicator
        shouldPreventDefaultFocusOnSelectRow={!DeviceCapabilities.canUseTouchScreen()}
        showLoadingPlaceholder={!didScreenTransitionEnd || !OptionsListUtils.isPersonalDetailsReady(personalDetails)}
    />
</View>

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect bottom and top padding

What is the root cause of that problem?

We have extra padding at ta number of places, we need to update the style at 3 components:

App/src/pages/InviteReportParticipantsPage.tsx

Line 218 in 8d73db3

<View style={[styles.flexShrink0, styles.p5]}>

App/src/pages/InviteReportParticipantsPage.tsx

Line 202 in 8d73db3

<View style={[styles.flex1, styles.p1]}>

extra margin:

App/src/pages/InviteReportParticipantsPage.tsx

Line 223 in 8d73db3

containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto, styles.mb5]}

What changes do you think we should make in order to solve the problem?

Update the style to make the top padding as 0:

App/src/pages/InviteReportParticipantsPage.tsx

Line 218 in 8d73db3

<View style={[styles.flexShrink0, styles.p5]}>

<View style={[styles.flexShrink0, styles.p5, styles.pt0]}> 

Remove the bottom margin:

App/src/pages/InviteReportParticipantsPage.tsx

Line 223 in 8d73db3

containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto, styles.mb5]}

containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto]}

remove the extra padding:

App/src/pages/InviteReportParticipantsPage.tsx

Line 202 in 8d73db3

<View style={[styles.flex1, styles.p1]}>

<View style={[styles.flex1]}>

The above style changes will be inline with the Workspace invite members page:

Workspace Invite Members Page	Updated Group Invite Members Page

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0112cf7031d552a86f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[mallenexpensify]

Looks like this should be super quick/easy so I'm setting the price at $125. @thesahindia , 👀 plz on the above proposals

[melvin-bot]

📣 @zdradaa! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[zdradaa]

Remove extra space below the footer button and remove padding around the RHP content

[melvin-bot]

📣 @SachinNautiyal-gitHub! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[SachinNautiyal-gitHub]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01b7353984e10e506c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[SachinNautiyal-gitHub]

Proposal

Please re-state the problem that we are trying to solve in this issue.
extra padding and margin on top and bottom

What is the root cause of that problem?

extra padding at number of places

Root cause of issue - Extra margin in "App/src/pages/InviteReportParticipantsPage.tsx" in these lines -
line 202 - <View style={[styles.flex1, styles.p1]}>
line 218 - <View style={[styles.flexShrink0, styles.p5]}>
line 223 - containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto, styles.mb5]}

What changes do you think we should make in order to solve the problem?

line 202 - - remove the extra padding
line 218 - <View style={[styles.flexShrink0, styles.p5, styles.pt0]}> - update top padding 0
line 223 - containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto]} - remove the bottom margin.

[melvin-bot]

Triggered auto assignment to @madmax330, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[ShridharGoel]

@shawnborton Do we need to remove the padding above the button as well? The OP doesn't mention it, I think it looks better if we keep the padding above the button.

[shawnborton]

I think we'd probably remove it, or basically, let's do exactly what we do on the Start a Chat page.

[allgandalf]

Great, thanks @shawnborton ! :) already covered this in the selected proposal :)

[melvin-bot]

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [fix]: Incorrect padding in group invite flow in RHP #42728

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @thesahindia requires payment through NewDot Manual Requests
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia / @allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia / @allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia / @allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia / @allgandalf] Determine if we should create a regression test for this bug.
• [@thesahindia / @allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [fix]: Incorrect padding in group invite flow in RHP #42728

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @thesahindia requires payment through NewDot Manual Requests
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia / @allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia / @allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia / @allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia / @allgandalf] Determine if we should create a regression test for this bug.
• [@thesahindia / @allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[thesahindia]

It came from #39757. It was a big PR and this issue was hard to prevent. I don't think we need the checklist here. Also no need for a test case.

[mallenexpensify]

Contributor: @allgandalf paid $125 via Upwork
Contributor+: @thesahindia owed $125 via NewDot

Thanks!

[JmillsExpensify]

$125 approved for @thesahindia