[fix]: Incorrect padding in group invite flow in RHP #42728

allgandalf · 2024-05-28T22:35:06Z

Details

This PR fixes extra padding on invite members page for group invite

Fixed Issues

$ #42594
PROPOSAL: #42594 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Create a group
Click on the header > members>invite member
Observe the padding surrounding the whole thing and the button at the bottom

(This PR removed the extra padding for the button)

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Online	Offline

iOS: Native

Online	Offline
	$

iOS: mWeb Safari

Online	Offline

MacOS: Chrome / Safari

Online	Offline

MacOS: Desktop

Online	Offline

melvin-bot · 2024-05-28T22:35:11Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-05-28T22:45:58Z

My builds are failing on both Android and iOS i will update then by tomorrow

thesahindia · 2024-05-29T22:27:37Z

The padding is still present in the ios app

allgandalf · 2024-05-30T23:43:39Z

bulid on android still failing, i will test again tomorrow :)

allgandalf · 2024-05-31T10:25:04Z

have pushed latest changes @thesahindia , once you complete your review we will tag Shawn to verify the styles just to be double sure that we applied the right styles

thesahindia · 2024-05-31T15:34:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

thesahindia

Looks good!

allgandalf · 2024-05-31T17:38:11Z

tagging @shawnborton for one final look as you reported this issue :), you can see the result screenshots. (if my desktop and MacOS screenshots are not visible enough, please check @thesahindia 's screenshots)

shawnborton · 2024-06-03T07:41:47Z

src/pages/InviteReportParticipantsPage.tsx

    return (
        <ScreenWrapper
            shouldEnableMaxHeight
            testID={InviteReportParticipantsPage.displayName}
+            includeSafeAreaPaddingBottom={false}


Just curious, what does this do and why do we want it to be false here?

This is inline with our Guidelines:

App/contributingGuides/FORMS.md

Lines 321 to 326 in 79406ff

### Safe Area Padding

Any `FormProvider.js` that has a button will also add safe area padding by default. If the `<FormProvider>` is inside a `<ScreenWrapper>`, we will want to disable the default safe area padding applied there e.g.

```jsx

<ScreenWrapper includeSafeAreaPaddingBottom={false}>

Addtional context:

App/src/components/ScreenWrapper.tsx

Lines 236 to 239 in 79406ff

// We always need the safe area padding bottom if we're showing the offline indicator since it is bottom-docked.

if (includeSafeAreaPaddingBottom || (isOffline && shouldShowOfflineIndicator)) {

paddingStyle.paddingBottom = paddingBottom;

}

Can you explain it to me like I am a child? 😄 Just to make sure I understand what it does and why we are setting it to false. Thanks!

yeahhh, so we display offline indicator when the user isn't connected to internet, we want to add extra bottom padding whenever we want to display the offline indicator, why you may ask, well we have a bottom bar for iOS, if we do not add extra padding then the offline indicator will be inline with the bottom bar, rest of the times, we do not want the extra padding to be present.

App/src/components/ScreenWrapper.tsx

Lines 236 to 239 in 79406ff

// We always need the safe area padding bottom if we're showing the offline indicator since it is bottom-docked.

if (includeSafeAreaPaddingBottom || (isOffline && shouldShowOfflineIndicator)) {

paddingStyle.paddingBottom = paddingBottom;

}

But as you can see above extra bottom padding will be added if includeSafeAreaPaddingBottom is true even when the user is online, hence we explicitly set includeSafeAreaPaddingBottom to false and let the extra padding come when the user is offline

Here we go,

If we set includeSafeAreaPaddingBottom to true:

Online Offline

If we set includeSafeAreaPaddingBottom to false:

Online Offline

Cool, yeah I think that helps validate that we should always be using true for iOS/Android.

Cool to conforming the requirements once:

For Desktop/Browser: We would set includeSafeAreaPaddingBottom to false.

For Android Native** and iOS Native** : We would set includeSafeAreaPaddingBottom to true.

Also, as mentioned we would need to make changes throughout the codebase where ever we have used this bottom button, so should we make a new issue for this or do all those changes in this PR itself @shawnborton ?

I'm fine if we have a new issue for this one so we don't block progress on this PR.

Agree on that :)

shawnborton · 2024-06-03T07:42:12Z

Will spin up a test build

github-actions · 2024-06-03T08:03:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42728/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42728/NewExpensify.dmg	https://42728.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-06-03T08:13:22Z

Design-wise this looks good to me, just one small comment about SafeArea

allgandalf · 2024-06-04T17:28:53Z

This is ready for merge @madmax330

OSBotify · 2024-06-05T06:40:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T23:32:43Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix styles

fa5f5d4

allgandalf requested a review from a team as a code owner May 28, 2024 22:35

melvin-bot bot removed the request for review from a team May 28, 2024 22:35

melvin-bot bot requested a review from thesahindia May 28, 2024 22:35

allgandalf added 2 commits May 30, 2024 19:08

Merge branch 'Expensify:main' into issue42594

cbbeeeb

Merge branch 'Expensify:main' into issue42594

62d4d85

make footer component

47d2391

remove view

dc88f9d

thesahindia approved these changes May 31, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 May 31, 2024 15:35

shawnborton reviewed Jun 3, 2024

View reviewed changes

shawnborton added the Ready To Build label Jun 3, 2024

madmax330 approved these changes Jun 5, 2024

View reviewed changes

madmax330 merged commit 432c2e7 into Expensify:main Jun 5, 2024
38 checks passed

github-actions bot mentioned this pull request Jun 6, 2024

Deploy Checklist: New Expensify 2024-06-06 #43168

Closed

melvin-bot bot mentioned this pull request Jun 11, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$125] Incorrect padding in group invite flow in RHP #42594

Closed

6 tasks

allgandalf mentioned this pull request Jun 20, 2024

[HOLD for payment 2024-08-05] [$250] Bottom docked button views does not use correct SafeSpace in mobile #44056

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix]: Incorrect padding in group invite flow in RHP #42728

[fix]: Incorrect padding in group invite flow in RHP #42728

allgandalf commented May 28, 2024 •

edited

Loading

melvin-bot bot commented May 28, 2024

allgandalf commented May 28, 2024

thesahindia commented May 29, 2024

allgandalf commented May 30, 2024

allgandalf commented May 31, 2024

thesahindia commented May 31, 2024

thesahindia left a comment

allgandalf commented May 31, 2024

shawnborton Jun 3, 2024

allgandalf Jun 3, 2024

allgandalf Jun 3, 2024

shawnborton Jun 3, 2024

allgandalf Jun 3, 2024

allgandalf Jun 3, 2024

shawnborton Jun 3, 2024

allgandalf Jun 3, 2024 •

edited

Loading

shawnborton Jun 3, 2024

allgandalf Jun 3, 2024

shawnborton commented Jun 3, 2024

github-actions bot commented Jun 3, 2024

shawnborton commented Jun 3, 2024

allgandalf commented Jun 4, 2024

OSBotify commented Jun 5, 2024

OSBotify commented Jun 11, 2024

	### Safe Area Padding

	Any `FormProvider.js` that has a button will also add safe area padding by default. If the `<FormProvider>` is inside a `<ScreenWrapper>`, we will want to disable the default safe area padding applied there e.g.

	```jsx
	<ScreenWrapper includeSafeAreaPaddingBottom={false}>

	// We always need the safe area padding bottom if we're showing the offline indicator since it is bottom-docked.
	if (includeSafeAreaPaddingBottom \|\| (isOffline && shouldShowOfflineIndicator)) {
	paddingStyle.paddingBottom = paddingBottom;
	}

[fix]: Incorrect padding in group invite flow in RHP #42728

[fix]: Incorrect padding in group invite flow in RHP #42728

Conversation

allgandalf commented May 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 28, 2024

allgandalf commented May 28, 2024

thesahindia commented May 29, 2024

allgandalf commented May 30, 2024

allgandalf commented May 31, 2024

thesahindia commented May 31, 2024

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

allgandalf commented May 31, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allgandalf Jun 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shawnborton commented Jun 3, 2024

github-actions bot commented Jun 3, 2024

shawnborton commented Jun 3, 2024

allgandalf commented Jun 4, 2024

OSBotify commented Jun 5, 2024

OSBotify commented Jun 11, 2024

allgandalf commented May 28, 2024 •

edited

Loading

allgandalf Jun 3, 2024 •

edited

Loading