Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track expense - "Only visible to you" whisper appears after scanning is complete #43839

Closed
6 tasks done
m-natarajan opened this issue Jun 17, 2024 · 10 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.84-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Go to + > Track expense > Scan.
  4. Upload a valid receipt.
  5. After 30 minutes, go to Troubleshoot > Clear cache and restart > Reset and refresh (because tracked expense won't update on its own after scanning is complete).
  6. Go to self DM.

Expected Result:

"Only visible to you" whisper will not appear after scanning is complete.

Actual Result:

"Only visible to you" whisper appears after scanning is complete.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

20240617_185653.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jun 17, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 17, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@rlinoz
Copy link
Contributor

rlinoz commented Jun 17, 2024

I am seeing this in both prod and staging, can you please confirm @m-natarajan?

@m-natarajan
Copy link
Author

@rlinoz in production, only visible to you is not shown when receipt is scanning and also after completed. But in staging it does show when scanning and even after completed.
Not sure if this is same RCA as #42169

@rlinoz
Copy link
Contributor

rlinoz commented Jun 17, 2024

Oh I got it...yeah, it looks like the same root cause as the issue you pointed to, thanks!

Although it is weird that it doesn't happen in prod, let me investigate.

@rlinoz
Copy link
Contributor

rlinoz commented Jun 17, 2024

Ok, it is coming from this changes from 0 to -1:

93a45ce#diff-f0bdc7ab41060e24e6bcdc847f25185b372c5f9a072251fe5d3cae2a27887920R519

I don't think they are doing anything wrong, it just uncovers the same problem the other issue linked issue #42169 is addressing.

We can close this in favor of that issue, given the real problem is in the backend since the message has the properties to make it a whisper.

@rlinoz rlinoz removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 17, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Jun 17, 2024

Closing in favor of #42169

@rlinoz rlinoz closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants