Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-09-17][Search v2.2] [App] Create status bar (Chat) #46588

Closed
luacmartins opened this issue Jul 31, 2024 · 17 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jul 31, 2024

Implement this section of the design doc

Issue OwnerCurrent Issue Owner: @twisterdotcom
@luacmartins luacmartins added the Daily KSv2 label Jul 31, 2024
@luacmartins luacmartins self-assigned this Jul 31, 2024
@luacmartins luacmartins moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Jul 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

@luacmartins
Copy link
Contributor Author

Still waiting on doc reviews.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 6, 2024
@luacmartins
Copy link
Contributor Author

@Expensify/design can I get the Invoices and Trips illustrations exported for App use please? https://www.figma.com/design/YHaWaw3F0PgxqI0tXHJVeY/Search-v1-v3?node-id=882-235709&t=KeEWs0szPlOnILzT-0

Screenshot 2024-08-09 at 7 57 29 PM Screenshot 2024-08-09 at 7 57 18 PM

@melvin-bot melvin-bot bot removed the Overdue label Aug 9, 2024
@dannymcclain
Copy link
Contributor

No prob.

Note

I'm pretty sure we want to use the luggage illustration for trips, not the briefcase, since it will match the menu item better.

simple-illustration__luggage.svg.zip
simple-illustration__envelopereceipt.svg.zip

CleanShot 2024-08-09 at 12 11 03@2x

@luacmartins
Copy link
Contributor Author

Thank you!

@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot removed the Overdue label Aug 13, 2024
@luacmartins luacmartins added the NewFeature Something to build that is a new item. label Aug 13, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Aug 13, 2024
@luacmartins
Copy link
Contributor Author

@shubham1206agra will be taking on the implementation!

@melvin-bot melvin-bot bot removed the Daily KSv2 label Aug 13, 2024
@shubham1206agra
Copy link
Contributor

@Expensify/design Can I get the illustration for chat please?

@shawnborton
Copy link
Contributor

Here you go: simple-illustration__commentbubbles.svg.zip

@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review and removed Weekly KSv2 labels Aug 27, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue labels Aug 31, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Sep 10, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins
Copy link
Contributor Author

This PR was deployed to production yesterday.

@luacmartins luacmartins changed the title [Search v2.2] [App] Create status bar (Chat) [HOLD for payment 2024-09-17][Search v2.2] [App] Create status bar (Chat) Sep 11, 2024
@luacmartins luacmartins added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Sep 11, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 Overdue labels Sep 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2024
@shubham1206agra
Copy link
Contributor

Not overdue

@twisterdotcom
Copy link
Contributor

Payment due in next Tuesday (I'll be out, so I'll try to pay out Monday/Wednesday).

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 12, 2024
@twisterdotcom
Copy link
Contributor

Okay, payment summary (@luacmartins correct me if the price is wrong. I'm defaulting to $250 because nothing else was specified here and there's no High Priority label.

@luacmartins
Copy link
Contributor Author

@twisterdotcom prices are correct. We've been paying the default $250 for all search related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

6 participants