Count is always shown as 1 new message when there are multiple unread messages in the new MarkerBadge

[parasharrajat]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open any conversation in newDot.
2. Scroll back in the history to see the new Markerbadge when new messages are received.
3. Send a new message from another device to the correct chat from the other user.
4. See that the new Marker badge is shown.
5. Now don't yet interact with the app or marker yet.
6. Send another message from the other device.
7. Observe that count is still 1.

Expected Result:

The count should increase to see the correct number.

Actual Result:

The count is always one.

Workaround:

None.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.85.-5
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

issue-marker.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[parasharrajat]

Explanation:

1. We should this.props.report.unreadActionCount in the Markerbadge.
2. But every time a message is received the this.props.report.unreadActionCount reset code is executed

   App/src/pages/home/report/ReportActionsView.js

   Line 199 in 8b10c1c

   updateLastReadActionID(this.props.reportID);

Proposal after Triage is done...

[mallenexpensify]

Proposal after Triage is done...
👍 @parasharrajat

I'm not seeing this

I tried to message myself between desktop and web on two different accounts, with web being on staging.
@parasharrajat , any idea why I'm not seeing the notification?

[parasharrajat]

Sorry @mallenexpensify, this is yet to be deployed to staging or PROD #4603

[mallenexpensify]

Should we wait for it to hit one or both before attempting a fix/update?
Or.. put another way... If I'm unable to test, then it's hard for me to recommend we should make this update.

[parasharrajat]

Yes. I am holding it till #4603. Created the issue so that it can be fixed quickly.

[parasharrajat]

@mallenexpensify the PR just hit Staging and the issue is now active.

[mallenexpensify]

Took a min (aka, I needed to read your steps, ha) but I was able to reproduce on web, staging.

At one point I did actually see the number rise to 3 but it most commonly was returning 1.

Gonna move along to an engineer to ensure this can be an external issue :)

[MelvinBot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[roryabraham]

This should not have gotten the Overdue label right as I applied the External label. Thats not right

[MelvinBot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[laurenreidexpensify]

@dylanexpensify I'm OOO next week and swamped with allocation reviews today so reassigning to get this added to Upwork thanks!

[MTN718]

Proposal (Shane Watson from Upwork)

1. In ReportActionView.js, updateLastReadActionID calling always. so it is reseting last unread message number
2. So add code there, reset unread message when marker only not showing,in other word only reset scroll to end.
3. And when scroll to end of bottom, reset unread number because currently unread update function when component update.
4. Adding screenshot for code for make sense

5. This is working video

Screen.Recording.2021-08-20.at.10.51.14.PM.mov

[parasharrajat]

Explanation here #4669 (comment)

Proposal

1. above functionality is necessary to mark the messages read but on the other hand, we want to show the marker to show the correct messages.
2. To do the above, we can create a count in the state which we update on every new message after the marker is shown as this.state.isMarkerActive.
3. We reset this count when the maker hides (When clicking close on it, users scroll down and the marker hides).
4. We store the report unread count in this state variable this.props.report.unreadActionCount.

[roryabraham]

@parasharrajat Your proposal looks good. @laurenreidexpensify Please hire @parasharrajat for this job on Upwork.

[MTN718]

I added solution also. and it works like video. I already tested on my local and uploaded video and proposal

[roryabraham]

@MTN718 I think your solution that changes calls of updateLastReadActionID to happen in relation to this.state.isMarkerActive might have some unintended side-effects (it makes an API call that may affect other platforms). So that's why I prefer @parasharrajat's solution of keeping a local count in the component state.

[dylanexpensify]

@roryabraham I'll send offer to @parasharrajat !

[dylanexpensify]

Offer sent!

[roryabraham]

PR was deployed to staging earlier today

[roryabraham]

Oops, Awaiting Payment was premature, should be added when the PR is deployed to prod.

[alex-mechler]

The current fix added a deploy blocker here: #4863

[roryabraham]

This was deployed to production w/ regressions fixed in v1.0.88-2 – Should pay on Monday 9/6 (Labor Day) assuming no other regressions are found 🙂

[parasharrajat]

@dylanexpensify Any update for me on the Upwork job?

[parasharrajat]

@dylanexpensify hmm. 🍷

[dylanexpensify]

Hi @parasharrajat! Sorry for the delay! I was OOO - will work on this today! @roryabraham no further regressions, correct?

[dylanexpensify]

@parasharrajat payment has been sent! Job closed out. Great work team!