RHP Navigation - Weird goBack behaviour

[shubham1206agra]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue reported by: @shubham1206agra
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1719319215720149

If we perform goBack with a fallback route to a FullScreen Navigator from RHP, it will create another Full Screen Navigator on top of the original Full Screen Navigator instead of just popping the RHP screen.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Use goBack without a fallback route.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-06-25.at.5.55.17.PM.mov

cc @adamgrzybowski @mountiny

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jliexpensify]

I'll just wait for @adamgrzybowski to comment so I can assign him

[melvin-bot]

@jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jliexpensify]

Not overdue, looking to assign @adamgrzybowski once he comments

[adamgrzybowski]

Hey @jliexpensify @shubham1206agra, I can't open the Slack thread. Could you please remind me why we can't just use goBack without the fallback route?

[jliexpensify]

Sure, this is (I think) what is relevant to your question?

But @shubham1206agra can weigh in and summarise.

[adamgrzybowski]

Great thanks! You can assign me but could we please set like to the lowest priority possible? I am currently working on POC with some changes in navigation and these changes may help with this issue. I will have this issue in mind and test it after finishing implementing navigation changes.

[jliexpensify]

Sure, assigned - I'm not sure which project this falls into though?

[adamgrzybowski]

There is an issue that started my work on POC. Not sure if it falls into any project but the closest would be the ideal-nav. I think we finished it some time ago though.

[jliexpensify]

Hmm ok, in that case - it's probably going to be project-less? @adamgrzybowski I have set this to Weekly but let me know if you'd like it Monthly instead.

[adamgrzybowski]

Maybe monthly? I am going to be OOO soon for two weeks 😄 We don't want to upset Melvin

[jliexpensify]

Easy, done! I assume you'll be working on this solo - i.e. no need for payments to anyone, except maybe a C+ who might review a PR?

[adamgrzybowski]

Correct!

[melvin-bot]

@jliexpensify @adamgrzybowski this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[jliexpensify]

@shubham1206agra this is still happening, correct? Could you please list out the flow/reproduction steps so we can better understand the actual issue and how we can prioritise it (especially since another issue has been now linked)? Thank you!

[jliexpensify]

Bump @shubham1206agra on my comment here

[jliexpensify]

Hi @shubham1206agra - can you address my question here?

Similarly, @adamgrzybowski - what's your own priority for this issue? Has it changed?

[adamgrzybowski]

Hi! We are currently refactoring navigation. We have a draft PR here and one of the changes is the new goBack function. Those are pretty big changes, so we are still looking for regressions and are unsure if this version of the goBack solves the issue above or if it needs more adjustments.

If someone could test our branch it would be great 🙇 If not, we will do it after removing the draft label from PR.

[jliexpensify]

Awesome, thanks for the update! Would this go under the NewDot-Quality project?

[mountiny]

@jliexpensify I dont think bz person is required here so I have unassigned you, added it to the quality project as low and will monitor this. thanks!

[mountiny]

no updates

[mountiny]

Will be handled as part of the ongoing navigation changes

[mountiny]

low