[HOLD for payment 2024-09-18] [$50] Android – Workspace settings–Hmm page appears briefly when open just invited member settings

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.31-12
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4943069
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in as a new Gmail account
3. Create a workspace
4. Tap on Members and invite an existing member
5. Tape on this member in the members list

Expected Result:

Member settings opens

Actual Result:

Hmm page appears briefly then member settings opens

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6598238_1725939011592.Hmm_page.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833426923481644605
• Upwork Job ID: 1833426923481644605
• Last Price Increase: 2024-09-10
• Automatic offers:
• shubham1206agra | Reviewer | 103898293

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hmm page appears briefly then member settings opens

What is the root cause of that problem?

When we open the member details page, the policy Onyx data might still be loading and gets fallback to empty object {} thus causing member to be undefined and show not found page:

App/src/pages/workspace/withPolicyAndFullscreenLoading.tsx

Line 30 in e56d529

{policy = policyDefaultProps.policy, policyDraft = policyDefaultProps.policyDraft, ...rest}: Omit<TProps, keyof WithPolicyAndFullscreenLoadingOnyxProps>,

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Line 66 in 881bc10

const member = policy?.employeeList?.[memberLogin];

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Lines 173 to 174 in 881bc10

	const shouldShowNotFoundPage =
	!member || (member.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && prevMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);

What changes do you think we should make in order to solve the problem?

Leverage the useOnyx's FetchStatus metadata to know whether we're still loading data.

1. In withPolicy:

const [policy, policyResults] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`);
const [policyDraft, policyDraftResults] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${policyID}`);
const isLoadingPolicy = isLoadingOnyxValue(policyResults, policyDraftResults);

2. Pass isLoadingPolicy to WithPolicyAndFullscreenLoading
3. Show loading indicator if isLoadingPolicy:

App/src/pages/workspace/withPolicyAndFullscreenLoading.tsx

Lines 36 to 38 in 1725041

	if (isLoadingReportData && isEmpty(policy) && isEmpty(policyDraft)) {
	return <FullscreenLoadingIndicator />;
	}

(isLoadingPolicy || isLoadingReportData) && isEmpty(policy) && isEmpty(policyDraft)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833426923481644605

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[shubham1206agra]

@mkzie2 Can you tell me the offending PR here please?

[VickyStash]

@shubham1206agra it looks like this is the offending PR: #48297

UPD: It looks like after updates applied in the mentioned PR inside withPolicy HOC the policy prop is not defined for a couple of first ms on the WorkspaceMemberDetailsPage.
Which makes the member be undefined here:

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Line 66 in fe4d19e

const member = policy?.employeeList?.[memberLogin];

And showing NotFoundPage here:

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Lines 173 to 178 in fe4d19e

	const shouldShowNotFoundPage =
	!member || (member.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && prevMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
	if (shouldShowNotFoundPage) {
	return <NotFoundPage />;
	}

[MariaHCD]

Thanks, @VickyStash! Since we needed this solved with some urgency, @VickyStash has included the fix in this PR: #48872

[melvin-bot]

Upwork job price has been updated to $50

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.31-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix app crash when viewing member profile after Expensify Card feature is enabled #48872

If no regressions arise, payment will be issued on 2024-09-18. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Reviewer)
• @mkzie2 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @mkzie2 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1833426923481644605/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@JmillsExpensify, @MariaHCD, @mkzie2 Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Payment summary:

• Contributor: @mkzie2 $50
• Reviewer: @shubham1206agra $50

[shubham1206agra]

@JmillsExpensify I accepted the offer.

[melvin-bot]

@JmillsExpensify, @MariaHCD, @mkzie2 Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

@mkzie2 are you due payment on this issue?

[MariaHCD]

@mkzie2 is due $50 for their proposal: #48867 (comment)

[JmillsExpensify]

Offer sent!

[mkzie2]

Offer accepted

[melvin-bot]

@JmillsExpensify, @MariaHCD, @mkzie2 Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

All done here.