[HOLD for payment 2024-11-11] [$250] Subject of the room briefly displayed {"html": "subject here"} before it finished rendering

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason @jliexpensify
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1726583603519899

Action Performed:

1. Go the social room using very slow internet connection

Expected Result:

Room details loads without any error

Actual Result:

Subject of the room briefly displayed {"html": "subject here"} before it finished rendering

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838604064730634601
• Upwork Job ID: 1838604064730634601
• Last Price Increase: 2024-10-08
• Automatic offers:
• truph01 | Contributor | 104425070

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @techievivek (AutoAssignerNewDotQuality)

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[sonialiap]

Jli is BZ and reported this issue so I'll unassign myself

[jliexpensify]

Hmm this isn't an issue for me anymore - I had a period of slow internet while I was at a cafe yesterday and didn't see any problems. @coleaeason what about you - still seeing it?

[jliexpensify]

Had a report of this issue over the weekend from DB

[jliexpensify]

I just got this again, as I started this morning:

Precondition: Offline from ND for an extended period (e.g. 8 hours/overnight)

1. Open laptop and click on #social
2. Observe HTML and also notice no chats loaded since 2:38am AEST
3. Type message and refresh
4. Wait ~60 seconds
5. See the channel title reflect properly

Is this something you can look into @techievivek?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021838604064730634601

[melvin-bot]

@coleaeason, @jliexpensify, @techievivek, @abdulrahuman5196 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@coleaeason @jliexpensify @techievivek @abdulrahuman5196 @truph01 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[truph01]

@techievivek I created draft PR here.

I encounter an issue with the change log message: When I tried to update the report's description, I sent description: {"html":"test"} to BE via API UpdateRoomDescription based on comment. The response contains the change log:

<muted-text>set the room description to: {"html":"test"}</muted-text>

So in FE, it is displaying that message as:

[techievivek]

@truph01 I am working on the backend changes for this and realized we can just send the description in plain text and then in backend I can add checks to confirm we insert it as json.

[truph01]

PR is ready

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Subject of the room briefly displayed as json string #50838

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment through NewDot Manual Requests
• @truph01 requires payment automatic offer (Contributor)

[melvin-bot]

@abdulrahuman5196 @jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[jliexpensify]

Bumping @abdulrahuman5196 for the checklist please

[abdulrahuman5196]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This is bug caused by backend-Frontend incompatability. We don't have access to backend code to report this.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

1. Go to any room
2. Update the room's description
3. Send any message
4. Verify the room's description displayed properly

Do we agree 👍 or 👎

@jliexpensify

[jliexpensify]

Payment Summary

• C: @truph01 $250 (owed via Upworks)
• C+: @abdulrahuman5196 $250 (owed via ND payments)

Upwork job

[JmillsExpensify]

$250 approved for @abdulrahuman5196