-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QBO - Changing to other option does not save for the first time #49372
Comments
Triggered auto assignment to @JmillsExpensify ( |
Triggered auto assignment to @grgia ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I added 2 labels because I am not sure what I need to use. The behavior with Recording.2826.mp4 |
Potentially related to #48277 |
@dangrous can you double check if the API |
Hm yeah it's on prod... And I just double checked the new code from your PR, it's effectively no different from the old code. @aldo-expensify do you think this might be the sync issue we're dealing with separately? Like the initial sync hasn't yet completed? |
yeah i think this is the sync issue - I just tried on my own staging account, the first time i switched the setting (right after connecting) it switched back, but then i just tried it again after waiting a few seconds, and it worked. @izarutskaya can you confirm if changing the setting - after waiting at least 10 seconds or so after connecting QBO - does work as intended? If so, I think we can close this and handle the syncing separately. |
@dangrous if you need any frontend work for it, I can help 😊 |
@dangrous the bug is specific to the first time |
testing again now |
![]() |
Right after I call
I see a call to
So after I refresh it's persisted the original call- technically it has saved |
Demoting as an app blocker since it's an erroneous onyx update |
I haven't checked it yet. I can try to take a look from FE side. |
Now I have my dev env fully working again. From testing I can see that the IS code call several times Considering this, I guess it is expected that the onyx updates will arrived in any order since:
This makes it very likely that some calls to |
No updates, I've been focusing on this other QBO quality issue: #49371 which has a more clear solution. |
Holding on #49371 before continuing in case the fix there helps with this too. |
Still waiting for #51110 to be reviewed... |
@JmillsExpensify, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
#51110 was merged, I'll get back on testing this asap |
Great! |
@JmillsExpensify, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
So I have been working today on this, and I have manage to reproduce it a few times, but is hard... most of the time you don't have enough time to go to the setting and change it. I have tried with slow connections and it doesn't make it easier. I'll be also OOO next week, so considering that and the above, I'll lower the priority to Having said that, I think I have an idea of how to fix this in the Integration-Server. The current behaviour is:
I want to change this to:
If we do a single |
Closing this, the backend PR was deployed last week: https://github.com/Expensify/Integration-Server/pull/8184 |
Thanks for sticking with this one, Aldo. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.0.37-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validation PR: #48277
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Prerequisite: Your workspace needs to connect with QBO.
Expected Result:
Chosen option saves
Actual Result:
When changing option for the first time Chosen option returns back to the initial option.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6607200_1726624177582.Screen_Recording_2024-09-18_at_4.28.11_at_night.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @aldo-expensifyThe text was updated successfully, but these errors were encountered: