-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-24] [$125] Remove deprecated ReportActionUtils.getParentReportAction method #49551
Comments
Triggered auto assignment to @sonialiap ( |
doh ignore for now! 🤦 |
Job added to Upwork: https://www.upwork.com/jobs/~021837202794110877572 |
Current assignee @sonialiap is eligible for the Bug assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
Upwork job price has been updated to $125 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Remove deprecated ReportActionUtils.getParentReportAction method What is the root cause of that problem?This is a new feature What changes do you think we should make in order to solve the problem?Remove all use of What alternative solutions did you explore? (Optional)NA |
ProposalPlease re-state the problem that we are trying to solve in this issue.What is the root cause of that problem?Remove deprecated ReportActionUtils.getParentReportAction method What changes do you think we should make in order to solve the problem?New request What alternative solutions did you explore? (Optional)we should remove the App/src/libs/ReportActionsUtils.ts Lines 337 to 347 in eab7d0e
|
This comment was marked as outdated.
This comment was marked as outdated.
ProposalPlease re-state the problem that we are trying to solve in this issue.The What is the root cause of that problem?The method is outdated due to improved What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)None considered necessary, as the deprecation notice already suggests using Onyx.connect() or withOnyx() |
Current assignee @sonialiap is eligible for the NewFeature assigner, not assigning anyone new. |
|
Sorry I haven't been following too closely, just diving in a bit more.
I see what you're saying now after looking at this file App/tests/actions/EnforceActionExportRestrictions.ts Lines 52 to 57 in 96aceca
👍, I wasn't aware we had tests like this, very cool and yeah makes sense to me. Going to assign you @nkdengineer |
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
@getusha is the next step here for you to review the PR? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment summary:
|
@bondydaa, @sonialiap, @getusha, @nkdengineer Eep! 4 days overdue now. Issues have feelings too... |
@bondydaa, @sonialiap, @getusha, @nkdengineer Still overdue 6 days?! Let's take care of this! |
This doesn't require a checklist. This issue is neither a bug nor a feature. |
$125 approved for @getusha |
Greater context in this issue #27262
Problem
We have marked this method as deprecate and need to remove it
App/src/libs/ReportActionsUtils.ts
Lines 337 to 347 in 97b51ac
Solution
I'm not seeing any usages of this method so I think we can probably just remove it.
I do see these 2 instances of a similar methods but I believe those are just the local functions and not using the
ReportActionUtils
method.App/src/libs/actions/Task.ts
Line 947 in 513e6b3
App/src/libs/actions/Task.ts
Lines 919 to 925 in 513e6b3
App/src/pages/home/ReportScreen.tsx
Line 126 in 513e6b3
App/src/pages/home/ReportScreen.tsx
Lines 92 to 97 in 513e6b3
If I missed something and we are using
ReportActionUtils.getParentReportAction
then we need to be sure to replace those with eitherwithOnyx()
orOnyx.connect()
cc @tgolen
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @getushaThe text was updated successfully, but these errors were encountered: