[$250] Task - Task name not updated in chat when it got changed offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.44.8
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5042712
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Open any chat
3. Click on "+" > Assign task
4. Add the the task name and create a task
5. Disable internet connection
6. Change the task name to something else
7. Return to the chat if needed

Expected Result:

The updated task name is displayed in the chat

Actual Result:

The old task name is still displayed in the chat

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6623583_1727981806919.Recording__836.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021842218862975991434
• Upwork Job ID: 1842218862975991434
• Last Price Increase: 2024-10-04

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-10-04 09:12:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The old task name is still displayed in the chat when updating task name offline

What is the root cause of that problem?

There have been an unsynchronization issue between Onyx data subscribed in component via useOnyx and the data in utils file:

App/src/components/ReportActionItem/TaskPreview.tsx

Line 76 in 92eee5f

const taskTitle = Str.htmlEncode(TaskUtils.getTaskTitle(taskReportID, action?.childReportName ?? ''));

App/src/libs/TaskUtils.ts

Line 41 in 9b7af88

const taskReport = ReportConnection.getAllReports()?.[`${ONYXKEYS.COLLECTION.REPORT}${taskReportID}`] ?? {};

Causing the utils file data to be stale (not updated).

What changes do you think we should make in order to solve the problem?

There have been many issues like #49551 to remove usages of using Onyx.connect in utils files, we should pass Onyx data directly from component instead and let these utils file only handle its utility.

So in this case, update getTaskTitle to receive taskReport directly instead of taskReportID and pass it from TaskPreview.

There are 2 usages of getTaskTitle, we need to update them accordingly.

What alternative solutions did you explore (Optional)?

We can update the task's parent report action's childReportName optimistically when editing task title:

App/src/libs/actions/Task.ts

Line 497 in 52aa9a9

function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task) {

because it's used as a fallback task title:

App/src/components/ReportActionItem/TaskPreview.tsx

Line 76 in 92eee5f

const taskTitle = Str.htmlEncode(TaskUtils.getTaskTitle(taskReportID, action?.childReportName ?? ''));

[mkzie2]

Update proposal

• Add alternative solution

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021842218862975991434

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[flodnv]

@mkzie2 any idea which PR caused this regression?

@ishpaul777 what are your thoughts on the proposal?

[ishpaul777]

looking 👀

[ishpaul777]

@mkzie2's Proposal makes sense and seems to be working, but we should know the offending PR before moving forward with a fix and assigning a contributor

[mkzie2]

I tried reverting PR #49686, specifically this change and it fixed the issue though I haven't understood why.

[ishpaul777]

reverting here to confirm if its the offending PR

[ishpaul777]

Confirmed that reverting it fixes the issue

Screen.Recording.2024-10-04.at.10.14.47.PM.mov

[ishpaul777]

Since we can't understand why the PR causes the issue, instead of rushing a fix i think we should revert to unblock the deploy and let orignal author take care of this in a second try. Any thoughts @flodnv @jasperhuangg ??

---

The given solution works in my testing and i dont think there will be any side effects, its just that proposal does not provide enough Root cause Analysis

[jasperhuangg]

@ishpaul777 I'm happy with that, thanks a lot for investigating the revert.

[isagoico]

Unable to reproduce this issue on build v9.0.44-10. Task name got updated while offline and the changes were still displayed after going back online.

[jasperhuangg]

@dylanexpensify @ishpaul777 is owed $250 for this issue, no other payments required

[rayane-djouah]

RCA: #49086 (comment)

[dylanexpensify]

Payment summary:

Contributor+: @ishpaul777 $250 via Upwork

Please apply/request!

[dylanexpensify]

@ishpaul777 apply here! 🙇‍♂️

[ishpaul777]

@dylanexpensify Please send in invite 🙇

[dylanexpensify]

@ishpaul777 done!

[ishpaul777]

accepted invite

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

Ah ignore @adelekennedy I'll finish payment - @ishpaul777 sent offer!

[dylanexpensify]

this is done btw!