Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-25] [Wave Control] [QBD] Advanced settings main page #49714

Closed
lakchote opened this issue Sep 25, 2024 · 14 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lakchote
Copy link
Contributor

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).

Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.vnq8rnmobwkj

@lakchote lakchote self-assigned this Sep 25, 2024
@lakchote lakchote moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Sep 25, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 3, 2024
@lakchote lakchote changed the title [HOLD #49697] [Wave Control] [QBD] Advanced settings main page [Wave Control] [QBD] Advanced settings main page Oct 15, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 16, 2024
@melvin-bot melvin-bot bot changed the title [Wave Control] [QBD] Advanced settings main page [HOLD for payment 2024-10-25] [Wave Control] [QBD] Advanced settings main page Oct 18, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

@dylanexpensify dylanexpensify moved this from Release 3: Fall 2024 (Nov) to Hold for Payment in [#whatsnext] #expense Oct 18, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

Issue is ready for payment but no BZ is assigned. @trjExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Oct 25, 2024

Payment Summary

Upwork Job

BugZero Checklist (@trjExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@trjExpensify
Copy link
Contributor

👋 checklist time!

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Oct 25, 2024

Oh
Crup
We forgot @hoangzinh 😅

@trjExpensify
Could you please assign him as he reviewed this PR ?

@trjExpensify
Copy link
Contributor

Done!

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
@hoangzinh
Copy link
Contributor

Regression Test Proposal

Prerequisites:

  • Turn on Beta quickbooksDesktopOnNewDot on your account
  • Connect your workspace to QBD
  1. Sign-in on the account above
  2. Go to the connected QBD Workspace -> Accounting
  3. Click on "Advanced" menu under QBD connection
  4. Verify that there are 2 toggle buttons "Auto-sync" and "Auto-create entities"
  5. Verify that the toggles work correctly

Do we agree 👍 or 👎

@melvin-bot melvin-bot bot removed the Overdue label Oct 28, 2024
@trjExpensify
Copy link
Contributor

Ah, @lakchote will the QBD regression tests get added centrally once the project launches?

Payment summary as follows:

@hoangzinh
Copy link
Contributor

Thanks @trjExpensify. I submitted an expense in ND.

@lakchote
Copy link
Contributor Author

lakchote commented Oct 29, 2024

Ah, @lakchote will the QBD regression tests get added centrally once the project launches?

Yes an issue has been created for it.

@garrettmknight
Copy link
Contributor

$250 approved fro @hoangzinh

@trjExpensify
Copy link
Contributor

Perfect. Paid @ZhenjaHorbach, closing!

Copy link

melvin-bot bot commented Oct 29, 2024

@trjExpensify @lakchote Be sure to fill out the Contact List!

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

5 participants