[QBD] Export settings main page #50164

ZhenjaHorbach · 2024-10-03T15:38:33Z

Details

[Wave Control] [QBD] Export settings main page

Fixed Issues

Related to #49707, will fix it once there aren't TODO items anymore.
PROPOSAL:

Tests

Open app
Open workspace with a set Quickbooks Online
Navigate to https://dev.new.expensify.com:8082/settings/workspaces/${policyId}/accounting/quickbooks-desktop/export
Verify that export screen is open

Verify that no errors appear in the JS console

Offline tests

Open app
Open workspace with a set Quickbooks Online
Navigate to https://dev.new.expensify.com:8082/settings/workspaces/${policyId}/accounting/quickbooks-desktop/export
Verify that export screen is open

QA Steps

Open app
Open workspace with a set Quickbooks Online
Navigate to https://dev.new.expensify.com:8082/settings/workspaces/${policyId}/accounting/quickbooks-desktop/export
Verify that export screen is open

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-03T16:21:02Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-10-03T16:21:34Z

@hoangzinh
@lakchote

PR is ready !

allgandalf · 2024-10-03T16:22:14Z

Does this need a C+ review ? @ZhenjaHorbach @hoangzinh @lakchote

ZhenjaHorbach · 2024-10-03T16:22:39Z

@allgandalf
Sorry for assignment
But we already have reviewers !

allgandalf · 2024-10-03T16:23:07Z

Can my review be dismissed here please

ZhenjaHorbach · 2024-10-03T16:24:26Z

Can my review be dismissed here please

Unfortunately, I can't =(

hoangzinh · 2024-10-03T17:21:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

![Screenshot 2024-10-04 at 14 51 49](https://github.com/user-attachments/assets/8dcc565d-a0e2-4892-8951-736aedc1db84)

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

hoangzinh · 2024-10-03T17:22:55Z

@ZhenjaHorbach the PR title saying "Advanced settings main page" but PR is about "Export main page". Can you check again?

ZhenjaHorbach · 2024-10-03T17:25:34Z

@ZhenjaHorbach the PR title saying "Advanced settings main page" but PR is about "Export main page". Can you check again?

Oh
Sorry
I pasted the wrong text
Fixed

hoangzinh · 2024-10-03T17:27:13Z

src/pages/workspace/accounting/qbd/export/QuickbooksDesktopExportPage.tsx

+        {
+            description: translate('workspace.accounting.preferredExporter'),
+            onPress: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_PREFERRED_EXPORTER.getRoute(policyID)), // TODO: should be updated to use new routes
+            title: qboConfig?.export?.exporter ?? policyOwner,


Is it a clone page from QBO? we have to put a lot of todo line here.

Yes, according to docs export settings main screens are very similar
And I think there will be enough TODO here
https://github.com/Expensify/App/pull/50164/files#diff-d3e40fcf1fbd0236640562b12ae6c7cf27ff38980417a0f97dbc1d0e74ff563aR22
Since when qbd config will be ready we will need to test the correctness of the data

hoangzinh

LGTM for a backbone PR

src/languages/es.ts

lakchote

Left a comment, also modified Fixed issues text in your PR as it won't fix the related issue since there are TODO items.

lakchote · 2024-10-04T15:29:57Z

src/pages/workspace/accounting/qbd/export/QuickbooksDesktopExportPage.tsx

+            displayName={QuickbooksDesktopExportPage.displayName}
+            headerTitle="workspace.accounting.export"
+            title="workspace.qbd.exportDescription"
+            accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN]}


Should we modify this, to gate access to users who are on the beta for QBD too?

Good idea
Done !

lakchote

Added comment related to the QBD beta and accessVariants

src/pages/workspace/accounting/qbd/export/QuickbooksDesktopExportPage.tsx

OSBotify · 2024-10-07T08:53:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-07T22:29:06Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.46-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

github-actions · 2024-10-09T20:28:55Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.46-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-11-05T00:19:43Z

src/pages/workspace/accounting/qbd/export/QuickbooksDesktopExportPage.tsx

+            titleStyle={styles.ph5}
+            shouldBeBlocked={!canUseNewDotQBD} // TODO: remove it once the QBD beta is done
+            connectionName={CONST.POLICY.CONNECTIONS.NAME.QBO} // TODO: should be updated to use the new connection
+            onBackButtonPress={() => Navigation.goBack(ROUTES.POLICY_ACCOUNTING.getRoute(policyID))}


Looks like having a fallback to the goBack function here led to the following issue:

[HOLD for payment 2024-11-11] [$250] Distance - Receipt disappears when dismissing distance editor after receipt is generated #48630

which was fixed by removing the fallback, more details in the proposed solution.

Thanks for the heads up @ikevin127.

cc @ZhenjaHorbach @hoangzinh for visibility

ZhenjaHorbach added 3 commits October 3, 2024 17:30

Create QuickbooksDesktopExportPage and update routes

9a98d28

Update folder name

9581d14

update deepDiveExpensifyCard message

6b01554

ZhenjaHorbach marked this pull request as ready for review October 3, 2024 16:20

ZhenjaHorbach requested a review from a team as a code owner October 3, 2024 16:20

melvin-bot bot requested review from allgandalf and removed request for a team October 3, 2024 16:21

ZhenjaHorbach changed the title ~~[Wave Control] [QBD] Advanced settings main page~~ [Wave Control] [QBD] Export settings main page Oct 3, 2024

hoangzinh reviewed Oct 3, 2024

View reviewed changes

hoangzinh approved these changes Oct 4, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote October 4, 2024 07:56

lakchote reviewed Oct 4, 2024

View reviewed changes

src/languages/es.ts Show resolved Hide resolved

lakchote reviewed Oct 4, 2024

View reviewed changes

ZhenjaHorbach changed the title ~~[Wave Control] [QBD] Export settings main page~~ [QBD] Export settings main page Oct 4, 2024

lakchote reviewed Oct 4, 2024

View reviewed changes

ZhenjaHorbach added 2 commits October 4, 2024 18:20

update branch

edb07a0

add beta for qbd

256a747

lakchote reviewed Oct 7, 2024

View reviewed changes

src/pages/workspace/accounting/qbd/export/QuickbooksDesktopExportPage.tsx Outdated Show resolved Hide resolved

add shouldBeBlocked for QuickbooksDesktopExportPage

082240d

lakchote approved these changes Oct 7, 2024

View reviewed changes

lakchote merged commit 7981265 into Expensify:main Oct 7, 2024
17 checks passed

github-actions bot mentioned this pull request Oct 7, 2024

Deploy Checklist: New Expensify 2024-10-07 #50366

Closed

50 tasks

lakchote mentioned this pull request Oct 9, 2024

[HOLD for payment 2024-11-07] [Wave Control] [QBD] Remove all the "TODO: [QBD]" in related pages #50499

Closed

This was referenced Oct 15, 2024

[Wave Control] [QBD] [Export] Export Expensify card transactions #49713

Closed

[$250] [Wave Control] [QBD] Export settings main page #49707

Closed

ikevin127 reviewed Nov 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QBD] Export settings main page #50164

[QBD] Export settings main page #50164

ZhenjaHorbach commented Oct 3, 2024 •

edited by lakchote

Loading

melvin-bot bot commented Oct 3, 2024

ZhenjaHorbach commented Oct 3, 2024

allgandalf commented Oct 3, 2024

ZhenjaHorbach commented Oct 3, 2024

allgandalf commented Oct 3, 2024

ZhenjaHorbach commented Oct 3, 2024

hoangzinh commented Oct 3, 2024 •

edited

Loading

hoangzinh commented Oct 3, 2024

ZhenjaHorbach commented Oct 3, 2024

hoangzinh Oct 3, 2024

ZhenjaHorbach Oct 3, 2024 •

edited

Loading

hoangzinh left a comment

lakchote left a comment

lakchote Oct 4, 2024

ZhenjaHorbach Oct 4, 2024

lakchote left a comment

OSBotify commented Oct 7, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 9, 2024

ikevin127 Nov 5, 2024

lakchote Nov 5, 2024

[QBD] Export settings main page #50164

[QBD] Export settings main page #50164

Conversation

ZhenjaHorbach commented Oct 3, 2024 • edited by lakchote Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 3, 2024

ZhenjaHorbach commented Oct 3, 2024

allgandalf commented Oct 3, 2024

ZhenjaHorbach commented Oct 3, 2024

allgandalf commented Oct 3, 2024

ZhenjaHorbach commented Oct 3, 2024

hoangzinh commented Oct 3, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh commented Oct 3, 2024

ZhenjaHorbach commented Oct 3, 2024

hoangzinh Oct 3, 2024

Choose a reason for hiding this comment

ZhenjaHorbach Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

hoangzinh left a comment

Choose a reason for hiding this comment

lakchote left a comment

Choose a reason for hiding this comment

lakchote Oct 4, 2024

Choose a reason for hiding this comment

ZhenjaHorbach Oct 4, 2024

Choose a reason for hiding this comment

lakchote left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 7, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 9, 2024

ikevin127 Nov 5, 2024

Choose a reason for hiding this comment

lakchote Nov 5, 2024

Choose a reason for hiding this comment

ZhenjaHorbach commented Oct 3, 2024 •

edited by lakchote

Loading

hoangzinh commented Oct 3, 2024 •

edited

Loading

ZhenjaHorbach Oct 3, 2024 •

edited

Loading