Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Attachment - Console error on preview page of Large PDF uploaded #49819

Open
1 of 6 tasks
IuliiaHerets opened this issue Sep 26, 2024 · 13 comments
Open
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.40-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5006507
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Log into staging.new.expensify.com and open any chat
  2. Tap "+" and tap Add attachment
  3. Upload "Large PDF File"

Expected Result:

No error in console appears

Actual Result:

A console error is shown on PDF preview page.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6615543_1727314388572!LARGE_PDF_FILE.pdf

Bug6615543_1727314388594.Screen_Recording_2024-09-25_at_7.13.58_PM.mp4

image (241)

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 26, 2024
Copy link

melvin-bot bot commented Sep 26, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Sep 27, 2024
@mallenexpensify
Copy link
Contributor

Bumping to weekly, will review next week since it's a console error

@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@mallenexpensify
Copy link
Contributor

Console error, not an immediate priority

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2024
@mallenexpensify mallenexpensify added the Needs Reproduction Reproducible steps needed label Oct 9, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@CyberAndrii
Copy link
Contributor

I've opened an issue in the upstream repo: mozilla/pdf.js#18876

Copy link

melvin-bot bot commented Oct 10, 2024

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2024
@mallenexpensify mallenexpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Oct 22, 2024
@mallenexpensify
Copy link
Contributor

@CyberAndrii , did you upstream PR fix this bug? I just tried to reproduce in Chrome with the file linked in the OP and I didn't see any console errors. Added retest-weekly here too

@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
@CyberAndrii
Copy link
Contributor

I can still reproduce this on staging v9.0.53-1. A new version of pdf.js that includes the fix will be released in about a week.

@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2024
@mallenexpensify
Copy link
Contributor

I'm off the next week, will address this once back.

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 15, 2024
@mallenexpensify
Copy link
Contributor

A new version of pdf.js that includes the fix will be released in about a week.

Reckon we're waiting on this. We have retest-weekly here so we should get a retest soon.

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2024
@mallenexpensify
Copy link
Contributor

Still kicking a can here, we're starting part deux for console error cleanup so this might be picked up there

@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2024
@mallenexpensify
Copy link
Contributor

Waiting

@melvin-bot melvin-bot bot removed the Overdue label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants