Console Error Cleanup part deux!

[mallenexpensify]

@kubabutkiewicz to work on the below.

• Sign in page - Console error shows when refreshing on the sign in page #52969 - this is a console error which I mentioned that its mentioned in other issues but this issue is specifically for fixing console error so we shouldn't close other
• [$250] Web - Attachment - Onyx and DataCloneError console rrrors when sending an image attachment #50780
• Web - Attachment - Console error on preview page of Large PDF uploaded #49819
• Go forward with a fix for cyclic dependencies which part of is the proposal on open source channel and this will be my main focus for now
• I would also dig into the app and look for more console errors because I know that there are more 😅

[kubabutkiewicz]

Hello, Im Jakub from Callstack and would like to help with this issue

[kubabutkiewicz]

@mallenexpensify Yeah, I will go through those issues and will post a massage about which ones we will handle in that issue 😄

[kubabutkiewicz]

@mallenexpensify I went through issues from your comment and this is my thoughts:

• [$250] Track expense - App crashes on report details RHP after submitting track expense to workspace #53547 - this seems to be normal bug and we shouldn't tackle it in that issue
• [$250] Track expense - App crashes on report details RHP after submitting track expense to workspace #53547 , Sign in page - Console error shows when refreshing on the sign in page #52969 are the same so we can close one of them and tackle it here
• [$250] Search-Invoice with +2 expense submitted in OD is displayed with a negative total amount in ND #53045 here console error is the same as above
• [$250] Workspace - Non-admin is not instantly removed from #admins member list after being demoted #53390 this seems to be normal bug and I don't see any console errors here
• [$250] Safari - Unable to play video attachment #52673 this also seems to be just a bug and error in the console its related to that bug
• [$250] Web - Thread - Switching to Search and back after clicking "Join thread" opens the report #52472 going through that issue I dont see anything about console errors
• Console Error on [react-native-gesture-handler] when view a video attachment in a report #52157 based on the comments in the issue it seems no longer reproducable
• [$250] Implement tests for reports that should not be displayed in LHN #52034 there are no console errors, its just issue for implementing tests
• BUG: Receipt is deleted if app is killed while request is in queue #51761 I think everything is sorted here, also I dont see any mentions about console errors
• [HOLD for payment 2024-11-18] [$250] iOS - App crashes when opening attachments in #expensify-roadmap public room #51181 this seems to be sorted out and soon will be closed
• [$250] Web - Attachment - Onyx and DataCloneError console rrrors when sending an image attachment #50780 this seems to be a bug in the Onyx, I can tackle it here
• [$250] Workflow - Added approval workflow doesn't respond to clicks for editing #49954 there is already contributor assigned to this bug and console errors are related to this bug so lets leave it for them
• Web - Attachment - Console error on preview page of Large PDF uploaded #49819 this seems to be already fixed on the lib side, so we need to wait till its released and then upgrade package in our repo
• [$250] Joined thread stuck in LHN with a 🔴 and it shows up twice in LHN. #47708 this seems to be a backend issue and no console errors
• Unable to upload HEIF image as money request (Web) #47078 there is already a contributor assigned and console error is caused that we are not supporting specific file extensions
• [HOLD #9402] Chat - ERR_FILE_NOT_FOUND console error shows up when uploading PDF file #46615 this seems to be already handled in other issue
• [HOLD E/App #38072] [$250] Storybook - Storybook is displaying a white page upon opening + console errors #40041 this seems to be on hold becasue of some internal initiative which is not a priority now

[mallenexpensify]

gulp, about to hop offline, will make a note to review tomorrow. Thx @kubabutkiewicz !

[kubabutkiewicz]

Shared a proposal for fixing warnings about cycle dependecies on open-source channel

[mallenexpensify]

Thanks for posting in #expensify-open-source @kubabutkiewicz , it looks like there's broad support to move forward with your plan. Would it be helpful to reorganize the list of links you posted above to denote which will be addressed with your plan? For dupes, can you comment on the one you'd recommend closing? (if not, I can get to next week, got a few other priorities before the weekend). Thx again, happy to be making progress here.

[kubabutkiewicz]

I will do it today @mallenexpensify !

[kubabutkiewicz]

@mallenexpensify So from the list above in that issue I would tackle those

• Sign in page - Console error shows when refreshing on the sign in page #52969 - this is a console error which I mentioned that its mentioned in other issues but this issue is specifically for fixing console error so we shouldn't close others
• [$250] Web - Attachment - Onyx and DataCloneError console rrrors when sending an image attachment #50780
• Web - Attachment - Console error on preview page of Large PDF uploaded #49819

Beside those from a list

• Go forward with a fix for cyclic dependencies which part of is the proposal on open source channel and this will be my main focus for now
• I would also dig into the app and look for more console errors because I know that there are more 😅

[mallenexpensify]

Thanks @kubabutkiewicz , OP updated

[kubabutkiewicz]

Hi leaving update about that

• I opened first pull request for fixing cycle dependencies warnings in metro console Fix cycle dependencies in metro console #53852
• After merging this I will open another one for adjusting eslint to enforce new style of imports
• Now I will be looking at this Sign in page - Console error shows when refreshing on the sign in page #52969

[kubabutkiewicz]

@mallenexpensify I was looking today at this issue #52969 and I believe we need to ask someone from infrastructure team or something like that, because the problem is that we have set up CSP (Content Security Policy) for some third party scripts but not for this one https://stats.g.doubleclick.net. I think we need just to add another entry to allow doubleclick.net domain in our CSP configuration but the configuration is not in the frontend repo.

[kubabutkiewicz]

In the meantime I will look at #50780 but for now I am not able to reproduce that.

[mallenexpensify]

Thx for the updates @kubabutkiewicz

ask someone from infrastructure team or something like that, because the problem is that we have set up CSP

Can you post in #expensify-callstack to see if anyone in that room might be able to help or provide feedback? If that doesn't work I can cross-post from there to an engineering chat room to get 👀