Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Supportal] Workspace expense does not load when clicked #50627

Open
1 of 6 tasks
stephanieelliott opened this issue Oct 11, 2024 · 31 comments
Open
1 of 6 tasks

[Supportal] Workspace expense does not load when clicked #50627

stephanieelliott opened this issue Oct 11, 2024 · 31 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@stephanieelliott
Copy link
Contributor

stephanieelliott commented Oct 11, 2024

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: LOGS
Expensify/Expensify Issue URL: N/A
Issue reported by: @stephanieelliott
Slack conversation: https://expensify.slack.com/archives/C07NZ8B1VTQ/p1728500635598069

Action Performed:

  1. Support log into a customer account (must be: owner on workspace with at least 1 expense submitted)
  2. Click New Expensify
  3. Click Search > Expenses
  4. Click on expense

Expected Result:

Expense thread should open with a link to workspace chat at the top (see right side of screen in video)

Actual Result:

Page shows endless loading, expense does not load.

Workaround:

None, this is problematic because it's currently the workaround for us to view workspace chats

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-10-10_22-08-22.mp4
Issue OwnerCurrent Issue Owner: @chiragsalian
Issue OwnerCurrent Issue Owner: @chiragsalian
@stephanieelliott stephanieelliott added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Oct 11, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@maddylewis maddylewis moved this to Support (HIGH) in [#whatsnext] #retain Oct 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@maddylewis maddylewis changed the title [Supportal] Workspace expense does not load when clicked on [Supportal] Workspace expense does not load when clicked Oct 14, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Oct 16, 2024

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

@dylanexpensify
Copy link
Contributor

Tackling this evening!

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
@dylanexpensify dylanexpensify removed their assignment Oct 18, 2024
@dylanexpensify dylanexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dylanexpensify
Copy link
Contributor

Hey @mallenexpensify! I'm heading out on parental leave so reassigning this! TY! 🙇‍♂️

@mallenexpensify
Copy link
Contributor

@stephanieelliott what should BZ do with supportal-related issues? I can update the team and add deets to What do I do when assigned a BugZero (Bug0) chore via the Bug label auto assigner?

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mallenexpensify
Copy link
Contributor

@stephanieelliott 👀 above plz. assigned to you and made you owner for a min

@stephanieelliott
Copy link
Contributor Author

Ah thanks for the bump @mallenexpensify! I'm thinking we just treat these as normal Internal E/A issues, no? I don't think we need a separate process for Supportal issues per se, I think the only unique thing about them is that they can only be worked on by internal Expensify eng (I think).

Are you thinking there are some other nuances that need to be documented for these?

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@mallenexpensify
Copy link
Contributor

Chatting with Steph about

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2024
Copy link

melvin-bot bot commented Nov 7, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Overdue label Nov 7, 2024
@mallenexpensify mallenexpensify self-assigned this Nov 7, 2024
@mallenexpensify
Copy link
Contributor

@Christinadobrzyn I'm off the next week, can you please keep an eye on this issue til I'm back? Thx. We're waiting for someone internal to pick up.

@Christinadobrzyn
Copy link
Contributor

sounds good! monitoring!

@Christinadobrzyn

This comment was marked as off-topic.

@Christinadobrzyn
Copy link
Contributor

update for Melvin - we're testing this!

@maddylewis maddylewis moved this from Support (HIGH) to Hot Picks in [#whatsnext] #retain Nov 12, 2024
@maddylewis maddylewis moved this from Hot Picks to Support (HIGH) in [#whatsnext] #retain Nov 12, 2024
@Christinadobrzyn
Copy link
Contributor

I just tested again and this is still happening - I'm getting a You do not have access to this chat too - which shouldn't be true through Supportal - we should be able to see everything.

2024-11-13_10-55-58.mp4

Tested when supportaling into [email protected]
Report 6801296288358808
Logs for report 6801296288358808
Error:
Failed to open report 6801296288358808 Expensify\Error\Auth\InsufficientPrivileges - c3a7c4f3-5768-4b91-bd98-7f38c1929b38 ~~ exceptionJsonCode: '411' exceptionUserMessage: 'You do not have the permission to do the requested action.' exceptionMessage: 'You do not have the permission to do the requested action.' exceptionFile: '/git/releases/expensify.com/121e77c/lib/Auth.php' exceptionLine: '267' exceptionCode: '666'

@chiragsalian chiragsalian self-assigned this Nov 13, 2024
@chiragsalian
Copy link
Contributor

Tested the fix and it seems to work fine for me locally. It's in review.

@chiragsalian chiragsalian added the Reviewing Has a PR in review label Nov 13, 2024
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Nov 14, 2024

Amazing! Thank you so much @chiragsalian! Updated Canvas about this status

@Christinadobrzyn
Copy link
Contributor

TY! Testing again:

  1. Supportal into [email protected]
  2. Click New Expensify
  3. Redirect to New Expensify for the user
  4. Click Search
  5. Click View for an expense
  6. "Hmm... it's not here You don't have access to this chat" error shows

Logs for supportaling into [email protected]

I can't find any other logs but it looks like this is still happening (sorry) @chiragsalian

2024-11-15_11-39-18 (4)

@chiragsalian
Copy link
Contributor

Weird, from the logs and the db it says those reports are not shared with [email protected]. I'm not exactly sure how the person sees those reports in Search and how OpenReport is supposed to work for them. Shall ask in engg-chat.

@Christinadobrzyn
Copy link
Contributor

Thanks @chiragsalian! Let me know if there's anything I can do to help test this.

@maddylewis maddylewis removed the Hot Pick Ready for an engineer to pick up and run with label Nov 18, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

@chiragsalian, @mallenexpensify, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@chiragsalian
Copy link
Contributor

Investigated with @luacmartins today and we found the source of the issue.
Its a relatively new bug that exist only on newDot and its only obvious because of the search feature.
We believe the issue for newdot is here. It needs to incorporate this code from oldDot.

While we believe we found the solution testing that will be a bit tricky to ensure nothing is broken. I'm a bit swamped so i don't think i can get to it this week and plus i don't think its a daily so I'll demote it to weekly. Aiming to tackle maybe next week. If you feel the priority is different let me know.

@chiragsalian chiragsalian added Weekly KSv2 and removed Daily KSv2 labels Nov 25, 2024
@maddylewis maddylewis moved this from Support (HIGH) to Polish (LOW) in [#whatsnext] #retain Dec 2, 2024
@Christinadobrzyn
Copy link
Contributor

Awesome thank you @chiragsalian!

@Christinadobrzyn
Copy link
Contributor

Hi @chiragsalian just checking on any update on this one! TY!

@chiragsalian chiragsalian removed the Reviewing Has a PR in review label Dec 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 10, 2024
@chiragsalian
Copy link
Contributor

Sorry, i haven't looked into it yet due to other higher priorities.

@melvin-bot melvin-bot bot removed the Overdue label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: Polish (LOW)
Development

No branches or pull requests

6 participants