[$250] Hybrid Android/iOS - Copilot - Email missing on Let's make sure it's you step

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #49445

Action Performed:

1. Open the app and log in
2. Navigate to the account settings > Security > Add copilot
3. Select an account
4. Select the access level and proceed to the next step
5. Confirm to add copilot

Expected Result:

The email to which one the magic code was sent is displayed

Actual Result:

The email to which one the magic code was sent is missing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6642393_1729619138804.video_2024-10-22_13-45-01.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849735612716912049
• Upwork Job ID: 1849735612716912049
• Last Price Increase: 2024-11-01

Issue Owner

Current Issue Owner: @s77rt

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[zanyrenney]

Where should the email be? Can you check the testing script please @lanitochka17 ? I don't think this is a bug.

[zanyrenney]

actually, going to take to channel.

[zanyrenney]

https://expensify.slack.com/archives/C049HHMV9SM/p1729802357760819

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849735612716912049

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[Rai7in]

Hi there,

I am coming here from Upwork.
https://www.upwork.com/jobs/250-Hybrid-Android-iOS-Copilot-Email-missing-Let-make-sure-you-step-51284-Expensify_~021849735612716912049/?referrer_url_path=find_work_home

Should I post my proposal in the comments here? Or is there any specific page of forms to submit the proposal?
I have read the contributing guidelines
It just states to submit the proposal here in the git issue comments. So I am not sure.

My upwork profile
https://www.upwork.com/freelancers/~016d4742bcd2c740f6?mp_source=share

Thanks,
Raghu

[melvin-bot]

📣 @Rai7in! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Rai7in]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~016d4742bcd2c740f6?mp_source=share

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Rai7in]

My Proposal for above issue:
As I see from the above issue, the root cause looks to be the email details are not added to the view text.
I am not sure on how the magic code to the selected mail is sent whether through android intent or by integrating with an email sending service (like Amazon SES etc).

And the requirement to show the activity/fragment "The email to which one the magic code was sent is displayed"

1. If it is immediately after the Intent or API call, the activity/fragment can be called with the email selected to be shown on the next screen.

2. If it is need to be shown after the mail is sent successfully, then we would have to implement the email sending functionality within the app using SMTP (Simple Mail Transfer Protocol) or by integrating with an email sending service that provides APIs for sending emails and receiving delivery status, with a waiting screen transition.

• Through this we can decide to move to the next page to show "The email to which one the magic code was sent is displayed along with the next actions"

• or can show the error status and can take action to validate/modify the mail before trying again.

This completely depends on the requirement and how to implement.

This is my proposal for the brief information given in the above problem statement/ issue description. If more details are available. The implementation can be further optimized.

Thanks,
Raghu.

[s77rt]

@Rai7in Welcome! Regarding your question you should comment just here on GitHub. Upwork is only used for payment and no discussion is done there. As for your proposal please use the proposal template as stated in contributing guide and provide a better RCA (e.g. why is the email not being added, link to the offending code or PR, etc.).

[melvin-bot]

@s77rt, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[s77rt]

Still looking for proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Same ^

[s77rt]

Same ^

[dangrous]

Should we maybe bump the price on this one?

[s77rt]

@dangrous I think this needs to be Internal? It does not seem like contributors can run the hybrid app

[melvin-bot]

@s77rt @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[dangrous]

I'm able to reproduce this on the staging app, but I can't get it locally yet. Not sure I can take this on, but just to call out - it seems like account?.primaryLogin isn't being loaded properly in android hybrid app. Dunno yet if that's on the account side or the primarylogin side. Or something else entirely!

[s77rt]

Yes, that seems to be the case.

@Julesssss May know how we handle bugs in the hybrid app

[Julesssss]

@Julesssss May know how we handle bugs in the hybrid app

Yeah, for now they need to remain internal

[melvin-bot]

@s77rt, @zanyrenney Huh... This is 4 days overdue. Who can take care of this?

[s77rt]

Do we need to add Hot Pick or how can get an engineer to look into this

[s77rt]

🎀 👀 🎀 Summoning 🪄🌟 🌟 ✨💫

[melvin-bot]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tgolen]

For internal issues, please open a separate GH issue using this template: https://github.com/Expensify/App/issues/new?assignees=&labels=Hot+Pick%2C+Daily%2C+Internal%2C+AutoAssignerNewDotQuality&projects=&template=Internal.md

(I'm happy to be assigned to it)

[dangrous]

@tgolen I made #52499

[s77rt]

Not overdue. Should we hold this on #52499? Not sure why we needed another issue, this one should be enough as it's still a frontend issue

[melvin-bot]

@tgolen, @s77rt, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[s77rt]

Same ^

[tgolen]

I think this issue can be closed. The other issue might not have been necessary because I thought it was a backend fix (in which case, the other issue would have been necessary). Anyway, it's a problem with Hybrid App, and it's being handled in #52499 so I'm gonna close this.