-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hybrid Android/iOS - Copilot - Email missing on Let's make sure it's you step #52499
Comments
Triggered auto assignment to @MarioExpensify ( |
@dangrous thanks for creating this, but it's written from the viewpoint of the UI. Can you please update it to explain the bug in terms of API calls and responses and what exactly needs to be fixed on the backend? |
So I think it IS a UI issue (the app has access to the necessary email already), it's only internal because contributors can't work on Mobile-Expensify. |
@dangrous sorry, I don't think I got it, is this a Mobile-Expensify bug? I think the issue is in the wrong repo then? Not sure how it should work for Mobile-Expensify issues. I can take a look at it anyways. Just making sure. |
Yeah I guess I'm a little confused too haha. I was following @tgolen's reco to create a separate internal issue, but maybe we should have this in Expensify/Expensify instead? |
I think this issue is fine in this repo and OK, I guess I didn't understand it was just a UI issue and not an API issue, but that doesn't change much (it just invalidates my earlier comment on this issue). |
Whoops, it seems this had both daily and weekly tags. Removing daily. |
Okay cool, so what is the next step on this? @MarioExpensify are you up for investigating this internally? Or @tgolen would you prefer to take over? |
Hey @dangrous, yes, I will work on this. |
Hey @dangrous, are you still able to reproduce this? I tested this both in ND and in Hybrid App and both seemed to work just fine |
So I think ND was always working. Let me see if I can replicate on Hybrid, maybe it got fixed by something else? And you were using Hybrid Android, right? |
oh i guess it happened on iOS too. I can't get android hybrid working with my local server, so im trying ios now |
IOS looks good! I am truly failing to run android locally in a way that works, do you think we can just close without testing? I don't love it but hopefully it is not different... |
@dangrous my test was done in Hybrid App Android, it looked good, but I'm sending this ticket to qa in Slack and requesting a retest just to be sure!! Edit: request sent |
@dangrous we got the QA results back and it seems it is Ok now. I'm closing the ticket but feel free to reopen if this ever comes back!! Thank you |
Original GH: #51284
Action Performed:
Expected Result:
The email to which one the magic code was sent is displayed
Actual Result:
The email to which one the magic code was sent is missing
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/4415e142-c336-4afb-a016-835dd9db51b9The text was updated successfully, but these errors were encountered: