Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Android/iOS - Copilot - Email missing on Let's make sure it's you step #52499

Closed
dangrous opened this issue Nov 13, 2024 · 16 comments
Closed
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@dangrous
Copy link
Contributor

Original GH: #51284

Action Performed:

  1. Open the app and log in
  2. Navigate to the account settings > Security > Add copilot
  3. Select an account
  4. Select the access level and proceed to the next step
  5. Confirm to add copilot

Expected Result:

The email to which one the magic code was sent is displayed

Actual Result:

The email to which one the magic code was sent is missing

Screenshots/Videos

Add any screenshot/video evidence https://github.com/user-attachments/assets/4415e142-c336-4afb-a016-835dd9db51b9
@dangrous dangrous added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Hot Pick Ready for an engineer to pick up and run with AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Nov 13, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

Triggered auto assignment to @MarioExpensify (AutoAssignerNewDotQuality)

@tgolen
Copy link
Contributor

tgolen commented Nov 13, 2024

@dangrous thanks for creating this, but it's written from the viewpoint of the UI. Can you please update it to explain the bug in terms of API calls and responses and what exactly needs to be fixed on the backend?

@dangrous
Copy link
Contributor Author

So I think it IS a UI issue (the app has access to the necessary email already), it's only internal because contributors can't work on Mobile-Expensify.

@MarioExpensify
Copy link
Contributor

@dangrous sorry, I don't think I got it, is this a Mobile-Expensify bug? I think the issue is in the wrong repo then? Not sure how it should work for Mobile-Expensify issues.

I can take a look at it anyways. Just making sure.

@dangrous
Copy link
Contributor Author

Yeah I guess I'm a little confused too haha. I was following @tgolen's reco to create a separate internal issue, but maybe we should have this in Expensify/Expensify instead?

@MarioExpensify
Copy link
Contributor

@dangrous I think so 😅 @tgolen if you can hop in

@tgolen
Copy link
Contributor

tgolen commented Nov 15, 2024

I think this issue is fine in this repo and OK, I guess I didn't understand it was just a UI issue and not an API issue, but that doesn't change much (it just invalidates my earlier comment on this issue).

@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
@MarioExpensify MarioExpensify removed the Daily KSv2 label Nov 18, 2024
@MarioExpensify
Copy link
Contributor

Whoops, it seems this had both daily and weekly tags. Removing daily.

@melvin-bot melvin-bot bot removed the Overdue label Nov 18, 2024
@dangrous
Copy link
Contributor Author

Okay cool, so what is the next step on this? @MarioExpensify are you up for investigating this internally? Or @tgolen would you prefer to take over?

@MarioExpensify
Copy link
Contributor

Hey @dangrous, yes, I will work on this.

@MarioExpensify
Copy link
Contributor

Hey @dangrous, are you still able to reproduce this? I tested this both in ND and in Hybrid App and both seemed to work just fine
image

@dangrous
Copy link
Contributor Author

So I think ND was always working. Let me see if I can replicate on Hybrid, maybe it got fixed by something else? And you were using Hybrid Android, right?

@dangrous
Copy link
Contributor Author

oh i guess it happened on iOS too. I can't get android hybrid working with my local server, so im trying ios now

@dangrous
Copy link
Contributor Author

IOS looks good! I am truly failing to run android locally in a way that works, do you think we can just close without testing? I don't love it but hopefully it is not different...

@MarioExpensify
Copy link
Contributor

MarioExpensify commented Nov 26, 2024

@dangrous my test was done in Hybrid App Android, it looked good, but I'm sending this ticket to qa in Slack and requesting a retest just to be sure!!

Edit: request sent

@MarioExpensify
Copy link
Contributor

@dangrous we got the QA results back and it seems it is Ok now. I'm closing the ticket but feel free to reopen if this ever comes back!! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants