[HOLD for payment 2024-11-21] [$100] mWeb - Inbox - The "Focus" popup can´t be closed by tapping outside of it.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. In an account with "Focus" mode enabled, change the mode to "Most Recent"
2. Log out of the account
3. Log in again to the same account
4. Verify if the "Focus Mode" popup is displayed
5. Verify if the popup can be closed by tapping outside of it

Expected Result:

The user should be able to close the "Focus Mode" popup by tapping on the screen outside of it

Actual Result:

When the "Focus" popup is displayed, the user can´t close it by tapping on the screen outside the popup

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6617549_1727453929539.Tap.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851098193336540822
• Upwork Job ID: 1851098193336540822
• Last Price Increase: 2024-10-29
• Automatic offers:
• situchan | Reviewer | 104668615
• ChavdaSachin | Contributor | 104668616

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Inbox - The "Focus" popup can´t be closed by tapping outside of it

What is the root cause of that problem?

We don't handle the backdrop press in FocusModeNotification.tsx

What changes do you think we should make in order to solve the problem?

We will add the onBackdropPress prop to FocusModeNotification.tsx here:

onBackdropPress={User.clearFocusModeNotification}

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• mWeb - Inbox - The "Focus" popup can´t be closed by tapping outside of it

What is the root cause of that problem?

• We do not handle onBackdropPress and onCancel , hence user is not able to close it by clicking on background nor using back button.

What changes do you think we should make in order to solve the problem?

• Add following props here, so user can close popup by clicking background and also using back button.

            onBackdropPress={User.clearFocusModeNotification}
            onCancel={User.clearFocusModeNotification}

App/src/components/FocusModeNotification.tsx

Lines 22 to 45 in 476ad6b

	<ConfirmModal
	title={translate('focusModeUpdateModal.title')}
	confirmText={translate('common.buttonConfirm')}
	onConfirm={User.clearFocusModeNotification}
	shouldShowCancelButton={false}
	prompt={
	<Text>
	{translate('focusModeUpdateModal.prompt')}
	<TextLinkWithRef
	style={styles.link}
	onPress={() => {
	User.clearFocusModeNotification();
	Link.openLink(href, environmentURL);
	}}
	>
	{translate('focusModeUpdateModal.settings')}
	</TextLinkWithRef>
	.
	</Text>
	}
	isVisible
	image={Illustrations.ThreeLeggedLaptopWoman}
	titleStyles={[styles.textHeadline, styles.mbn3]}
	/>

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[VictoriaExpensify]

Ok I think we should fix this, but it seems like a minor bug so I think we should reduce the bounty a bit. If I'm missing something to do with the complexity, please let me know

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851098193336540822

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Upwork job price has been updated to $100

[situchan]

@ChavdaSachin's proposal looks good to me, considering android back button behavior as meaningful difference.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ChavdaSachin 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[situchan]

@ChavdaSachin how's it going?

[ChavdaSachin]

capturing videos

[ChavdaSachin]

While capturing the video for web I faced new issue - navigating back using browser back button does not close focus popover. it is reproducible for web in both staging and production. Have to think a solution for that issue.

Check this video

Screen.Recording.2024-11-05.at.3.09.51.AM.mov

cc. @situchan

[cead22]

Looking! For some reason it didn't get automatically assigned to me (maybe it was this #52072 (comment))

[cead22]

I merged it

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• close focus notification when clicking backdrop or back button #52072

If no regressions arise, payment will be issued on 2024-11-21. 🎊

For reference, here are some details about the assignees on this issue:

• @ChavdaSachin requires payment automatic offer (Contributor)
• @situchan requires payment automatic offer (Reviewer)

[melvin-bot]

@cead22 @VictoriaExpensify @ChavdaSachin / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[VictoriaExpensify]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[VictoriaExpensify]

Hey @situchan - can you please complete the checklist and I'll get your payment sorted 😄

[VictoriaExpensify]

Payment Summary
Contributor: @ChavdaSachin paid $100 via Upwork

[melvin-bot]

@cead22, @VictoriaExpensify, @ChavdaSachin, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[VictoriaExpensify]

@situchan could you please complete the checklist? 🙏

#51432 (comment)

[VictoriaExpensify]

Bump @situchan

[melvin-bot]

@cead22, @VictoriaExpensify, @ChavdaSachin, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[VictoriaExpensify]

Oh I see @situchan is on parental leave. I think it's ok to move forward with payment and close this out.

[VictoriaExpensify]

Updated Payment Summary:
Contributor: @ChavdaSachin paid $100 via Upwork
C+: @situchan paid $100 via Upwork