-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Submit expense RHP doesn't include workspaces from Track flow #51552
Comments
Job added to Upwork: https://www.upwork.com/jobs/~021850835832011853233 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
Triggered auto assignment to @sonialiap ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Submit expense RHP doesn't include workspaces from Track flow What is the root cause of that problem?We do not include here for track expense
What changes do you think we should make in order to solve the problem?We should include track expense as well includeOwnedWorkspaceChats: (iouType === CONST.IOU.TYPE.SUBMIT || iouType === CONST.IOU.TYPE.CREATE || iouType === CONST.IOU.TYPE.SPLIT || iouType === CONST.IOU.TYPE.TRACK) && action !== CONST.IOU.ACTION.SUBMIT, ResultWhat alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Submit expense RHP doesn't include workspaces from Track flow What is the root cause of that problem?We are currently not allowing workspaces through the
and in participants we are not including workspaces if the action is submit
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional) |
Hi, @FitseTLT could you elaborate on this one? I'm unable to create a track expense with Distance request |
@hoangzinh Quite odd, I can create a distance track expense even without enabling beta 2024-10-29.14-27-05.mp4 |
My bad, I adjusted the code in Permission file 😮💨. Hey @FitseTLT, instead of removing above condition, is it better if we pass the iouType here
|
I am not following you @hoangzinh Why would we need to pass the iouType? |
Because we're allowing P2PDistanceRequests if it's a track request Lines 18 to 21 in c05e4df
|
@hoangzinh Here is some detail for context:
but now that, in this issue, we are allowing worspaces, we can allow the submit it to someone button whether the beta is enabled or not. I hope this will clear it up for you. |
I saw your point. Thanks @FitseTLT Agreed we can remove that condition |
@FitseTLT's proposal looks good to me. He pointed out the correct root cause. Also provided a solution that would solve all Track type Link to proposal #51552 (comment) 🎀👀🎀 C+ reviewed |
🎀👀🎀 C+ reviewed |
Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
bump for assignment @luacmartins |
📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@luacmartins I think now the copy |
IMO that still makes sense since you submit it to someone in your company. I think we can leave the copy as is for now. |
@shawnborton WDYT about the ^ |
I don't feel strongly, I can see an argument to just shorten the copy to "Submit it" but I think the idea is to match the exact copy used in the whisper, which is "Submit it to someone" right? |
I am talking about the whisper, should we change it? |
@hoangzinh, @sonialiap, @luacmartins, @FitseTLT Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I think we just leave the copy as it is for now. cc @jamesdeanexpensify @anmurali @danielrvidal in case you have strong feelings. Tldr; is that @FitseTLT is suggesting to change "Submit it to someone" to be just "Submit it" from the whisper (and now details view once this issue is implemented): I don't feel strongly. |
I think it's fine to keep as is |
We should also fix this bug as part of this issue |
This issue has not been updated in over 15 days. @hoangzinh, @sonialiap, @luacmartins, @FitseTLT eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Problem:
When you Track an expense, you can then submit it to someone. However, the list of contacts shown on this screen differs from the same contacts you would see if you first chose Submit expense from global create.
Track sees this:
Submit sees this:
Solution:
Let's make sure the Submit expense RHP flow looks identical no matter if you chose Track or Submit. This will fix the inconsistency in the product, and it also helps our chances for conversion as it unhides submitting an expense to a workspace from this flow.
cc @anmurali @JmillsExpensify to file this one, I think it is a #convert issue
We should also fix #52249 (comment) as part of this issue
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hoangzinhThe text was updated successfully, but these errors were encountered: