[HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] Room – Unable to save room description with numbers only

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log
3. Create a workspace
4. Create a room without description
5. Open room chat
6. Click on header, open description
7. Enter few numbers into description and save

Expected Result:

Description is saved

Actual Result:

Description is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6651150_1730381345048.bandicam_2024-10-31_15-20-54-852.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

Production:

bandicam.2024-10-31.09-39-05-128.mp4

[NJ-2020]

Regression PR: #50838

It's because when we set the room description to a number e.g 2222222 and when displaying the room description, we use getReportDescription function for the report description value

Inside this function we will parse the report.description using JSON parse and return the html value, if there's an error meaning the value could not be parse or something else, we will simply return report.description

App/src/libs/ReportUtils.ts

Lines 4261 to 4271 in 6c33bba

	function getReportDescription(report: OnyxEntry<Report>): string {
	if (!report?.description) {
	return '';
	}
	try {
	const reportDescription = report?.description;
	const objectDescription = JSON.parse(reportDescription) as {html: string};
	return objectDescription.html ?? '';
	} catch (error) {
	return report?.description ?? '';
	}

When we set the room description something like testsd not a number, it will work because the JSON parse cannot parse string value which will run this return statement

App/src/libs/ReportUtils.ts

Lines 4269 to 4271 in 6c33bba

	} catch (error) {
	return report?.description ?? '';
	}

But when we set a number value inside the room description, the JSON parse did not throw an error instead returning the report description number in type of number not string

So when there's no error this catch block will not run

App/src/libs/ReportUtils.ts

Lines 4269 to 4271 in 6c33bba

	} catch (error) {
	return report?.description ?? '';
	}

But instead it will run this

App/src/libs/ReportUtils.ts

Lines 4267 to 4268 in 6c33bba

	const objectDescription = JSON.parse(reportDescription) as {html: string};
	return objectDescription.html ?? '';

Since it's number so when we return objectDescription.html ?? '' it will return empty string

---

Instead of returning objectDescription.html ?? '' we can return this:

const reportDescription = report?.description;
const objectDescription = JSON.parse(reportDescription) as {html: string};
return objectDescription.html ?? report?.description ?? '';

[MuaazArshad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to save room description with numbers only.

What is the root cause of that problem?

We are passing only strings for the room description; if we receive a number, it cannot be processed as a string.
here

App/src/libs/ReportUtils.ts

Lines 4265 to 4271 in 6c33bba

	try {
	const reportDescription = report?.description;
	const objectDescription = JSON.parse(reportDescription) as {html: string};
	return objectDescription.html ?? '';
	} catch (error) {
	return report?.description ?? '';
	}

What changes do you think we should make in order to solve the problem?

We should cast numbers to string before processing like this

try {
        const reportDescription = report?.description;
        const objectDescription = JSON.parse(reportDescription) as {html: string};
        const newObjectDescription = {html:String(objectDescription)};
        return newObjectDescription.html ?? '';
    } catch (error) {
        return report?.description ?? '';
    }

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

@Gonals I can reproduce this, can this go external? Is it a blocker?

[Beamanator]

@NJ-2020 -thanks for finding what looks like the regression, i pinged the PR authors in slack 🙏

[truph01]

Working on it ...

[Beamanator]

PR looks great, I'll merge & CP very soon 👍

[Beamanator]

Note to @Christinadobrzyn : It looks like we're using @NJ-2020 's solution from here, so I believe they deserve some compensation even though they didn't make the PR

[Beamanator]

PR is being CP'd

[Beamanator]

Fixed in staging 👍 Not closing b/c #51789 (comment)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: cannot display description which contains only number #51943

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment through NewDot Manual Requests
• @truph01 requires payment (Needs manual offer from BZ)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: cannot display description which contains only number #51943

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment through NewDot Manual Requests
• @truph01 requires payment (Needs manual offer from BZ)

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @abdulrahuman5196 owed $250 via NewDot
• ROLE: @truph01 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[abdulrahuman5196]

Unassigning myself since i didn't work on this PR.

[Christinadobrzyn]

Payouts due:

• Contributor: $250 @truph01 (Upwork offer - https://www.upwork.com/nx/wm/offer/104890091) RETRACTED based on
• Contributor: 25% partial payment based on this $62.50 @NJ-2020 - (Upwork offer - https://www.upwork.com/nx/wm/offer/104893577)

Do we need a regression for this?

[NJ-2020]

Thank you @Christinadobrzyn @Beamanator

Sure here's my Upwork profile: https://www.upwork.com/freelancers/~01ff73ff788ecf5f2e

[truph01]

@Christinadobrzyn I create a follow-up PR, so no payment is needed for me

[Christinadobrzyn]

Thanks @NJ-2020! Can you please accept the Upwork offer so I can pay you? Thanks!

[NJ-2020]

Done accepted

[Christinadobrzyn]

Awesome! Thanks @NJ-2020 - I sent the payment through Upwork.

It does seem like a regression test would be good for this and since there was no C+ review, I'm discussing the best options to create one with QA. https://expensify.slack.com/archives/C9YU7BX5M/p1731570034074179

[Christinadobrzyn]

Sounds like QA already has a test for this and they are going to treat this as an edge case so no need to create a regression test. So we're good to close!