[HOLD for payment 2024-11-21] Re-direct to Classic when creating expenses for non-migrated users

[puneetlath]

There are scenarios where users who have not yet had their group workspaces NewDot-enabled in NewDot. In those scenarios, things can get confusing if they try to create expenses.

To address this, let's block them from Creating, Tracking, Submitting expenses from NewDot if they are:

• on at least one group policy
• none of the group policies they are a member of have isPolicyExpenseChatEnabled=true

We should do this by showing a modal when they tap/click any of these options, which re-directs them back to OldDot.

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[puneetlath]

@dubielzyk-expensify can you help with some mocks of what that re-direct to Classic modal should look like?

[dubielzyk-expensify]

Yes sir. Think we need some @jamesdeanexpensify magic to make the copy more crisp (he's back on Monday I believe).

Mocks

cc @Expensify/design for vizzzibilities

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Re-direct to Classic when creating expenses for non-migrated users

What is the root cause of that problem?

• It is new feature.

What changes do you think we should make in order to solve the problem?

• In FloatingActionButtonAndPopover, add a new modal:

            <ConfirmModal
                prompt={'Due to how your workspace is set up, submitting and tracking expenses has been disabled for now. Please go to Expensify Classic to add an expense.'}
                isVisible={modalVisible}
                onConfirm={() => {
                    setModalVisible(false);
                    Link.openOldDotLink(CONST.OLDDOT_URLS.INBOX);
                }}
                onCancel={() => setModalVisible(false)}
                title={'Your workspace is not ready for New Expensify'}
                confirmText={translate('exitSurvey.goToExpensifyClassic')}
                cancelText={translate('common.cancel')}
            />

• Then, introduce a new variable to check whether we should redirect user to OD:

    const [modalVisible, setModalVisible] = useState(false);
    const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY);
    const shouldRedirectToOD = useMemo(() => {
        const groupPolicies = Object.values(policies ?? {}).filter((policy) => ReportUtils.isGroupPolicy(policy));
        if (groupPolicies.length === 0) {
            return false;
        }
        return !groupPolicies.some((groupPolicy) => groupPolicy?.isPolicyExpenseChatEnabled);
    }, [policies]);

• Finally, update the callback function when clicking on Submit expense option:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Line 404 in 6463c2b

interceptAnonymousUser(() =>

                    interceptAnonymousUser(() => {
                        if (shouldRedirectToOD) {
                            setModalVisible(true);
                            return;
                        }
                        IOU.startMoneyRequest(
                            CONST.IOU.TYPE.SUBMIT,
                            // When starting to create an expense from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
                            // for all of the routes in the creation flow.
                            ReportUtils.generateReportID(),
                        );
                    }),

The similar should be applied with Track expense and Send invoice options.

What alternative solutions did you explore? (Optional)

[ishpaul777]

👋 I'll take this

[flaviadefaria]

Based on the latest discussions, I think this bow belongs to #retain, so I am assigning it there.

[jamesdeanexpensify]

@puneetlath @dubielzyk-expensify too much?

** 🚧 Under construction 🚧 **
We're fine-tuning a few more bits and pieces of New Expensify to accommodate your specific setup. In the meantime, head over to Expensify Classic.

[dubielzyk-expensify]

It's quite cute. But this feature is still available right, but it's just because the workspace has a complicated setup that we don't allow it? So maybe it feels a bit underselling?

[jamesdeanexpensify]

Updated it slightly. Anything else specific you wanna tweak? Happy to brainstorm.

[dubielzyk-expensify]

I like it. Keen to hear what @puneetlath thinks though

[puneetlath]

Sounds great to me! FYI @ishpaul777

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MariaHCD]

Looks like we have another flow in-product where we need to redirect to Classic: #52457

Would @ishpaul777 want to take that over as well? Or shall we treat it as a separate follow up?

[ishpaul777]

Happy to take it :) can raise a Pr in 6-8 hours

[ishpaul777]

Happy to take it :) can raise a Pr in 6-8 hours

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Re-direct to Classic when creating expenses for non-migrated users #51804 #51979

If no regressions arise, payment will be issued on 2024-11-21. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[puneetlath]

@suneox can you complete the checklist here?

[suneox]

BugZero Checklist

• [@suneox] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Proposal

Step 1: Create a control workspace on a new account in OldDot.
Step 2: Sign in to the same account on NewDot.
Step 3: Click on the FAB -> Create/Send/Track Expense.
Step 4: Verify that a “Coming Soon” modal is displayed.

Do we agree 👍 or 👎

[melvin-bot]

@puneetlath, @suneox, @ishpaul777, @dubielzyk-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

@ishpaul777 offer here: https://www.upwork.com/nx/wm/offer/105064871
@suneox offer here: https://www.upwork.com/nx/wm/offer/105064898

Can y'all ping me here when you've accepted?

Regression test GH: https://github.com/Expensify/Expensify/issues/447666

[ishpaul777]

Thank you! I have accepted the offer @puneetlath

[puneetlath]

@ishpaul777 has been paid.

[suneox]

I've accepted the offer. Thank you

[puneetlath]

Everyone has been paid now. Thanks everyone!