Re-direct to Classic when creating expenses for non-migrated users #51804 #51979

ishpaul777 · 2024-11-04T17:58:10Z

Explanation of Change

There are scenarios where users who have not yet had their group workspaces NewDot-enabled in NewDot. In those scenarios, things can get confusing if they try to create expenses.

To address this, we block them from Creating, Tracking, Submitting expenses from NewDot if they are:

on at least one group policy
none of the group policies they are a member of have isPolicyExpenseChatEnabled=true

Fixed Issues

$ #51804
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Create a few control workspace on new account on OD
Sign in with same account as OD in ND. Open FAB.
Verify Clicking Submit/Track/ send invoice shows redirect to OD modal.

Click on Go to Exfy Classic verify modal closes and you are redirected to OD
Open ND again and create a workspace, Open FAB
Verify Clicking Submit/Track/ send invoice does not shows redirect to OD modal

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-07.at.2.52.37.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-07.at.2.56.07.AM.mov

iOS: Native

Screen.Recording.2024-11-07.at.2.30.19.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-07.at.2.22.25.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-07.at.3.02.47.AM.mov

MacOS: Desktop

Screen.Recording.2024-11-07.at.3.11.05.AM.mov

ishpaul777 · 2024-11-04T18:07:40Z

@puneetlath Can you check if i am in right direction. 👇

it checks if there are group policies present, then checks if all policies have policy.isPolicyExpenseChatEnabled === false, if true it shows the modal

Screen.Recording.2024-11-04.at.11.24.21.PM.mov

puneetlath · 2024-11-04T18:27:56Z

That sounds correct to me!

ishpaul777 · 2024-11-04T18:33:12Z

Thanks for confirming, will you please get me copy confirmations and transations.

melvin-bot · 2024-11-06T21:43:23Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

suneox · 2024-11-07T03:47:47Z

It looks like the issue is still under discussion. I’ll complete the checklist once we finalize the message content.

puneetlath · 2024-11-07T15:22:40Z

Everything should be good to test. We're just finalizing copy.

suneox · 2024-11-08T04:18:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: Native

Screen.Recording.2024-11-10.at.18.31.45.mp4

iOS: mWeb Safari

Screen.Recording.2024-11-08.at.12.32.48.mp4

Android: Native

Screen.Recording.2024-11-08.at.12.49.39.mp4

Android: mWeb Chrome

Screen.Recording.2024-11-08.at.12.47.08.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-11-08.at.12.30.36.mp4

MacOS: Desktop

Screen.Recording.2024-11-08.at.12.31.26.mp4

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

ishpaul777 · 2024-11-09T13:25:30Z

src/languages/es.ts

+        redirectToOldDotModal: {
+            title: 'Próximamente',
+            description: 'Estamos ajustando algunos detalles de New Expensify para adaptarla a tu configuración específica. Mientras tanto, dirígete a Expensify Classic.',
+        },


asked confirmation here https://expensify.slack.com/archives/C01GTK53T8Q/p1731158680602489?thread_ts=1730917323.810119&cid=C01GTK53T8Q

suneox · 2024-11-10T12:29:20Z

@puneetlath, I’m not certain the condition none of the group policies they are a member of have isPolicyExpenseChatEnabled=true is working as expected. I have a legacy account only use newDot with several workspaces where isPolicyExpenseChatEnabled='1' which may be impact this check

Screen.Recording.2024-11-10.at.18.56.41.mp4

ishpaul777 · 2024-11-11T16:24:18Z

@puneetlath When can isPolicyExpenseChatEnabled be "1"? Is it any special case, or just for legacy workspaces

puneetlath · 2024-11-11T16:31:58Z

Hmm, interesting. I wasn't aware that was possible, so perhaps it's a legacy thing. In that case, can we create a helper function that checks if the value is either true or "1"?

suneox

The updated condition still works as expected.

puneetlath

Some small feedback.

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

src/languages/en.ts

OSBotify · 2024-11-11T19:21:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-13T01:08:55Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

IuliiaHerets · 2024-11-13T10:03:13Z

This PR is failing because of issues #52457 and #52460

github-actions · 2024-11-14T00:40:13Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.61-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

ishpaul777 added 2 commits November 4, 2024 23:26

v1 changes

460e4aa

prettier diffs

e4d7501

ishpaul777 changed the title ~~v1 changes~~ Re-direct to Classic when creating expenses for non-migrated users #51804 Nov 4, 2024

ishpaul777 and others added 4 commits November 6, 2024 23:21

Merge branch 'Expensify:main' into feat/51804

ae7644a

update copy

9861eed

fix trnslation

c977d35

fix modal hide

826b51c

ishpaul777 marked this pull request as ready for review November 6, 2024 21:43

ishpaul777 requested a review from a team as a code owner November 6, 2024 21:43

melvin-bot bot requested review from suneox and removed request for a team November 6, 2024 21:43

suneox reviewed Nov 8, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

suneox reviewed Nov 8, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Show resolved Hide resolved

ishpaul777 and others added 3 commits November 9, 2024 18:16

Merge branch 'Expensify:main' into feat/51804

6656f52

review comments

2436a60

fix copy

a48bd91

ishpaul777 commented Nov 9, 2024

View reviewed changes

ishpaul777 and others added 2 commits November 11, 2024 22:08

Merge branch 'Expensify:main' into feat/51804

2163bc9

handles legacy isPolicyExpenseChatEnabled

1aae872

ishpaul777 requested a review from suneox November 11, 2024 16:45

suneox approved these changes Nov 11, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath November 11, 2024 17:03

puneetlath requested changes Nov 11, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

src/languages/en.ts Outdated Show resolved Hide resolved

review comment changes

539de6e

puneetlath approved these changes Nov 11, 2024

View reviewed changes

puneetlath merged commit 9e85b9f into Expensify:main Nov 11, 2024
16 checks passed

github-actions bot mentioned this pull request Nov 13, 2024

Deploy Checklist: New Expensify 2024-11-13 #52440

Closed

41 tasks

IuliiaHerets mentioned this pull request Nov 13, 2024

[HOLD for payment 2024-11-28] Create expense button on empty Search page allows to create expense for non-migrated users #52457

Closed

8 tasks

IuliiaHerets mentioned this pull request Nov 13, 2024

OD Modal is not displayed with the same WS created in OD #52460

Closed

8 tasks

melvin-bot bot mentioned this pull request Nov 14, 2024

[HOLD for payment 2024-11-21] Re-direct to Classic when creating expenses for non-migrated users #51804

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-direct to Classic when creating expenses for non-migrated users #51804 #51979

Re-direct to Classic when creating expenses for non-migrated users #51804 #51979

ishpaul777 commented Nov 4, 2024 •

edited

Loading

ishpaul777 commented Nov 4, 2024

puneetlath commented Nov 4, 2024

ishpaul777 commented Nov 4, 2024

melvin-bot bot commented Nov 6, 2024

suneox commented Nov 7, 2024

puneetlath commented Nov 7, 2024

suneox commented Nov 8, 2024 •

edited

Loading

ishpaul777 Nov 9, 2024

suneox commented Nov 10, 2024

ishpaul777 commented Nov 11, 2024 •

edited

Loading

puneetlath commented Nov 11, 2024

suneox left a comment

puneetlath left a comment

OSBotify commented Nov 11, 2024

github-actions bot commented Nov 13, 2024

IuliiaHerets commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 14, 2024

Re-direct to Classic when creating expenses for non-migrated users #51804 #51979

Re-direct to Classic when creating expenses for non-migrated users #51804 #51979

Conversation

ishpaul777 commented Nov 4, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ishpaul777 commented Nov 4, 2024

puneetlath commented Nov 4, 2024

ishpaul777 commented Nov 4, 2024

melvin-bot bot commented Nov 6, 2024

suneox commented Nov 7, 2024

puneetlath commented Nov 7, 2024

suneox commented Nov 8, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 Nov 9, 2024

Choose a reason for hiding this comment

suneox commented Nov 10, 2024

ishpaul777 commented Nov 11, 2024 • edited Loading

puneetlath commented Nov 11, 2024

suneox left a comment

Choose a reason for hiding this comment

puneetlath left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 11, 2024

github-actions bot commented Nov 13, 2024

IuliiaHerets commented Nov 13, 2024 • edited Loading

github-actions bot commented Nov 14, 2024

ishpaul777 commented Nov 4, 2024 •

edited

Loading

suneox commented Nov 8, 2024 •

edited

Loading

ishpaul777 commented Nov 11, 2024 •

edited

Loading

IuliiaHerets commented Nov 13, 2024 •

edited

Loading