-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA]Fix Android Bumper (again) #52646
Conversation
package_name
and even better debug
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
upload_to_play_store( | ||
package_name: "org.me.mobiexpensifyg", | ||
json_key: './android/app/android-fastlane-json-key.json', | ||
version_code: productionVersionCode, | ||
version_code: productionVersionCodes.sort.last, # Get the latest version code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, where does this syntax come from?
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.0.64-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.64-4 🚀
|
Explanation of Change
I had a few more fixes to include to fix the Android Bumper:
google_play_track_version_codes
is returning an array, we have two versions returned, so we have to sort and get the largest to know which to bumpgoogle_play_track_version_codes
was missingpackage_name
Fixed Issues
Fixed broken workflow: https://github.com/Expensify/App/actions/runs/11861726215
Tests
Ran this manually here and verified it's working now: https://github.com/Expensify/App/actions/runs/11861864051
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop