Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA]Fix Android Bumper (again) #52646

Merged
merged 4 commits into from
Nov 15, 2024
Merged

[No QA]Fix Android Bumper (again) #52646

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bd7743
Update with `package_name` and even better debug
AndrewGable Nov 15, 2024
497a61f
Sort and grab last version code
AndrewGable Nov 15, 2024
4ef3090
Add s
AndrewGable Nov 15, 2024
686f620
Remove debug trigger
AndrewGable Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,15 @@ platform :android do

desc "Submit HybridApp to 100% rollout on Google Play"
lane :complete_hybrid_rollout do
productionVersionCode = google_play_track_version_codes(track: 'production')
productionVersionCodes = google_play_track_version_codes(
track: 'production',
package_name: "org.me.mobiexpensifyg",
json_key: './android/app/android-fastlane-json-key.json',
)
upload_to_play_store(
package_name: "org.me.mobiexpensifyg",
json_key: './android/app/android-fastlane-json-key.json',
version_code: productionVersionCode,
version_code: productionVersionCodes.sort.last, # Get the latest version code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, where does this syntax come from?

track: 'production',
rollout: '1',
skip_upload_apk: true,
Expand All @@ -283,14 +287,15 @@ platform :android do

desc "Update HybridApp rollout percentage on Google Play"
lane :update_hybrid_rollout do |options|
productionVersionCode = google_play_track_version_codes(
productionVersionCodes = google_play_track_version_codes(
track: 'production',
package_name: "org.me.mobiexpensifyg",
json_key: './android/app/android-fastlane-json-key.json',
)
upload_to_play_store(
package_name: "org.me.mobiexpensifyg",
json_key: './android/app/android-fastlane-json-key.json',
version_code: productionVersionCode,
version_code: productionVersionCodes.sort.last, # Get the latest version code
track: 'production',
rollout: options[:rollout],
skip_upload_apk: true,
Expand Down
Loading