Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hold for payment 2024-11-28] Payment issue for E/App PR#52656 #52676

Closed
melvin-bot bot opened this issue Nov 17, 2024 · 8 comments
Closed

[Hold for payment 2024-11-28] Payment issue for E/App PR#52656 #52676

melvin-bot bot opened this issue Nov 17, 2024 · 8 comments
Assignees
@sonialiap @allgandalf
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 17, 2024

Issue created to compensate the Contributor+ member for their work on #52656
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/444853.
Contributor+ member who reviewed the PR - @allgandalf.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Nov 17, 2024
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Nov 17, 2024
@melvin-bot melvin-bot bot mentioned this issue Nov 17, 2024
Merged
49 tasks
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 17, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 17, 2024
@sonialiap
Copy link
Contributor

sonialiap commented Nov 19, 2024 •
edited
Loading

Deployed to staging 8 hours ago. Payment likely on the 26th or a couple days later, depending on when it goes to prod. Updating title to 26 for tracking

@sonialiap sonialiap changed the title Payment issue for E/App PR#52656 [Hold for payment 2024-11-26] Payment issue for E/App PR#52656 Nov 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 21, 2024
@sonialiap
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2024
@sonialiap sonialiap added Weekly KSv2 and removed Daily KSv2 labels Nov 21, 2024
@sonialiap sonialiap changed the title [Hold for payment 2024-11-26] Payment issue for E/App PR#52656 [Hold for payment 2024-11-28] Payment issue for E/App PR#52656 Nov 21, 2024
@sonialiap
Copy link
Contributor

Hit prod 9 hours ago so updating the payment date to the 28th

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 24, 2024
@sonialiap
Copy link
Contributor

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Nov 26, 2024
@sonialiap
Copy link
Contributor

Payment summary:

@allgandalf
Copy link
Contributor

Thanks for the offer, I accepted it 😄

@sonialiap
Copy link
Contributor

🎉 thanks for the work, Rohan! Payment sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonialiap sonialiap

@allgandalf allgandalf

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sonialiap @allgandalf