-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't complete onboarding if not an invited user #52656
Conversation
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-11-17.at.9.26.21.PM.movAndroid: mWeb ChromeScreen.Recording.2024-11-17.at.9.35.17.PM.moviOS: NativeScreen.Recording.2024-11-17.at.9.37.09.PM.moviOS: mWeb SafariScreen.Recording.2024-11-17.at.9.38.25.PM.movMacOS: Chrome / SafariScreen.Recording.2024-11-17.at.8.58.14.PM.movMacOS: DesktopScreen.Recording.2024-11-17.at.9.00.38.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change tests well and LGTM
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🎯 @allgandalf, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #52676. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
The performance decrease is a false positive, no need to treat this as blocker |
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.64-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.64-4 🚀
|
Explanation of Change
Users that were not invited to Expensify by another user, but did go through the organic onboarding process were seeing the invite onboarding message when adding an account to their wallet. This PR adds a check to make sure the user has an
inviteType
set to theirintroSelected
NVP which is a property that will not be set for users the came to Expensify organically.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/444853
PROPOSAL: N/A
Tests
2024-11-15_15-42-43.mp4
Offline tests
N/A as Concierge requires connectivity
QA Steps
Same as the Test steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop