Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Track - Amount on the expense preview does not update when track distance expense is submitted #53988

Open
5 of 8 tasks
IuliiaHerets opened this issue Dec 12, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #51517
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Distance rates are enabled.
  • Workspace distance unit (miles) is different from individual distance unit (kilometers).
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track a distance expense.
  4. Click Share it with my accountant.
  5. Select the workspace.
  6. Click Rate.
  7. Select any rate.
  8. Click Submit.
  9. Note the amount on the expense preview in the main chat.
  10. Click on the expense preview.
  11. Go back to main chat.

Expected Result:

In Step 9, the amount on the expense preview should be the correct amount after the expense is created.

Actual Result:

In Step 9, the amount on the expense preview shows the old amount which is when a different rate is used in the track expense.
The amount only updates after refreshing the page (Step 11).

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6691743_1733973744772.20241212_110709.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021867155469395187403
  • Upwork Job ID: 1867155469395187403
  • Last Price Increase: 2024-12-12
  • Automatic offers:
    • paultsimura | Contributor | 105304884
Issue OwnerCurrent Issue Owner: @parasharrajat
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 12, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 12, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Different behavior in production

Screen.Recording.2024-12-12.at.11.00.13.AM.mov

@Pujan92
Copy link
Contributor

Pujan92 commented Dec 12, 2024

This is known issue and will be handled separately. Ref

cc: @paultsimura

@MariaHCD
Copy link
Contributor

Thanks, @Pujan92 !

@paultsimura @neil-marcellini would you both be able to take over this issue since it is a follow up from #51517 (review)

@paultsimura
Copy link
Contributor

would you both be able to take over this issue since it is a follow up from #51517 (review)

Yes, I'll start investigating the fix today.
Also IMO, it shouldn't be a blocker. This comment says the prod behavior is different, but it's only different because in prod the flow fails eventually – you can see the RBR appears after sharing the expense.

@MariaHCD MariaHCD added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 12, 2024
@melvin-bot melvin-bot bot changed the title Track - Amount on the expense preview does not update when track distance expense is submitted [$250] Track - Amount on the expense preview does not update when track distance expense is submitted Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021867155469395187403

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 12, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants