[HOLD for payment 2024-12-20] [$250] Track distance - Not here page opens after submitting track distance expense to new workspace

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Account has no workspace (new account).

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a distance expense.
4. Click Share it with my accountant.
5. Click Rate.
6. Select any rate.
7. Click Submit.

Expected Result:

The track distance expense is submitted to the workspace chat.

Actual Result:

Not here page opens after submitting track distance expense to a new workspace.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6691881_1733990287565.20241212_155552.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021867171525628939701
• Upwork Job ID: 1867171525628939701
• Last Price Increase: 2024-12-12

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Julesssss]

I believe this is the backend error, though it's possible a separate error:

UpdateMoneyRequestDistanceRate fails because customUnitRateID is passed, but is missing necessary fields. The transactionNVPs json must include customUnit and customUnit.name must be `Distance.

[Julesssss]

I'm not seeing any recent changes on the backend. There is a single App PR on the checklist related to distance customUnits, which I have commented on.

[paultsimura]

@Julesssss, I see this happens only in the no-workspace case when a new one is created automatically.
We never pass the customUnit.name in other API params and when sharing to an existing workspace, the flow works well, so I doubt this can be fixed on FE.

For my PR, a BE change was made previously – Web-E 44237. Could you please check maybe it's not handling this case correctly?

cc: @neil-marcellini

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021867171525628939701

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[Julesssss]

Thanks @paultsimura. That backend PR only modified tests unfortunately, so I don't think that can be the cause.

[paultsimura]

I don't know what transactionNVPs is or why UpdateMoneyRequestDistanceRate is triggered — I only call the ShareTrackedExpense API command from the FE. In my PR, we started passing the customUnitRateID to that API endpoint.

Maybe the BE doesn't handle it correctly when both conditions are met:

1. The customUnitRateID param is present
2. The workspace is a newly created one (why should it matter for the BE?)

Let me wait for @neil-marcellini and maybe we'll figure this out 👀

[shubham1206agra]

@paultsimura Maybe this is same as #51035

[paultsimura]

Great point @shubham1206agra – these 2 indeed look related.
@Julesssss, I see you wrote on the original GH that the BE change may not be prioritized soon. Maybe this use case can help bump it up?

[neil-marcellini]

Thanks @paultsimura. That backend PR only modified tests unfortunately, so I don't think that can be the cause.

@Julesssss It's linked to an Auth PR, which did make changes. @paultsimura sounds like we're going to revert this one since the error isn't reproducible on production, but is after our PR. The problem might very well be on the backend but this way it's not possible for users to encounter it until we fix it.

Would you please explain the root cause on the original issue. Any idea what's causing a problem on the backend or what error is returned? I haven't investigated myself yet but I can later.

[Julesssss]

Requested a retest here.

[isagoico]

Retest was a pass!

Untitled.video.6.mp4

[Julesssss]

Removing blocker

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "fix: distance - share with accountant" #54076

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

@shubham1206agra @mallenexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]