[HOLD for payment 2025-01-13] [HOLD for payment 2025-01-07] [$250] Track Expense - Website crashes when submitting a track expense.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Chat Report View

Action Performed:

1. Open the staging.new.expensify.com website.
2. Open Self DM.
3. Tap on "+" button and select "Create Expense"
4. Complete the expense creation flow.

Expected Result:

After creating a track expense, the user should land on self DM again and the expense details should be visible on the chat.

Actual Result:

Website crashes after submitting a track expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702794_1735282391342!log.txt

Bug6702794_1735281424305.Track_Crash.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021872615001903986307
• Upwork Job ID: 1872615001903986307
• Last Price Increase: 2024-12-27
• Automatic offers:
• brunovjk | Contributor | 105477339
• nkdengineer | Contributor | 105477345

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Website crashes after submitting a track expense.

What is the root cause of that problem?

We removed the fallback here then the app crashes when the chatReportID is changed from an empty string to an exist ID.

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 77 in e94df0f

const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${chatReportID}`);

App/src/pages/home/report/PureReportActionItem.tsx

Line 661 in e94df0f

chatReportID={ReportActionsUtils.getOriginalMessage(action)?.IOUReportID ? report?.chatReportID ?? '' : reportID}

What changes do you think we should make in order to solve the problem?

Bring the fallback ID back

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 77 in e94df0f

const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${chatReportID}`);

Or when we create the track expense we should set IOUReportID of the IOU action as 0 in optimistic data since BE also returns like this.

App/src/pages/home/report/PureReportActionItem.tsx

Line 661 in e94df0f

chatReportID={ReportActionsUtils.getOriginalMessage(action)?.IOUReportID ? report?.chatReportID ?? '' : reportID}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkuoch]

@brunovjk can you review this above proposal?

[brunovjk]

Sure!

[brunovjk]

@nkdengineer Your proposal makes sense to me. I’ve brought back the fallback ID using CONST.DEFAULT_NUMBER_ID here, and it resolves this specific issue.

However, in the original PR, we made changes in other locations to align with the new 'default-value-for-inexistent-ids' rule. I’m concerned these changes might have unintentionally impacted other flows, that I may not have considered, potentially leading to regressions like this one. Do you see other lines with useOnyx or related logic where we should reintroduce CONST.DEFAULT_NUMBER_ID in the MoneyRequestPreviewContent.tsx? Thank you

[nkdengineer]

Do you see other lines with useOnyx or related logic where we should reintroduce CONST.DEFAULT_NUMBER_ID in the MoneyRequestPreviewContent.tsx? Thank you

Bring the fallback ID back

@brunovjk The crash app will happen for the collect onyx keys then when I mentioned Bring the fallback ID that mean we need to update this for all useOnyx that connects with collection keys in MoneyRequestPreviewContent.

[nkdengineer]

App/src/pages/home/report/PureReportActionItem.tsx

Line 661 in e94df0f

chatReportID={ReportActionsUtils.getOriginalMessage(action)?.IOUReportID ? report?.chatReportID ?? '' : reportID}

Or we should fallback here to -1 instead of empty string.

[brunovjk]

Great! Thanks @nkdengineer, I think we can go with their proposal.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @nkuoch is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[brunovjk]

oops, I added 🎀 out of habit

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021872615001903986307

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[jasperhuangg]

Tests well! Thanks for the fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix app crashes when creating track expense #54622

If no regressions arise, payment will be issued on 2025-01-07. 🎊

For reference, here are some details about the assignees on this issue:

• @brunovjk requires payment automatic offer (Contributor)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@brunovjk @slafortune @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[brunovjk]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other: Applause Internal Team

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Feat: Add placeholder thumbnail to expenses with no receipt #52848 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  I don't believe a dedicated regression test is necessary for this case. The fix has been applied, and any further issues should surface quickly in future testing cycles.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix app crashes when creating track expense #54622

If no regressions arise, payment will be issued on 2025-01-13. 🎊

For reference, here are some details about the assignees on this issue:

• @brunovjk requires payment automatic offer (Contributor)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@brunovjk @slafortune @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@nkuoch, @slafortune, @brunovjk, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@nkuoch, @slafortune, @brunovjk, @nkdengineer Still overdue 6 days?! Let's take care of this!

[slafortune]

All paid 👍