Track expense when submitted to the workspace shows "owes" in preview and "tracking" in LHN

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Submit a manual expense to self DM.
4. Click Share it with my accountant.
5. Select any workspace if there are workspaces, or create a new one.
6. Enter merchant and submit it to the workspace chat.
7. Go to workspace chat.
8. Note that expense preview shows "spent x" and LHN shows "tracking x".
9. Delete the expense.
10. Go to self DM and submit a manual expense.
11. Select Submit it to someone.
12. Select a workspace and submit it to the workspace chat.
13. Go to workspace chat.

Expected Result:

If the submitted expense is supposed to be a non-track expense, the expense preview should show "owes x" and LHN should also shows "owes x".

If the submitted expense is supposed to be a track expense, the expense preview should show "spent x" and LHN should also shows "tracking x".

Actual Result:

The expense preview shows "owes x" and LHN shows "tracking x". It is giving unclear indication that the submitted expense could be 50% non-track expense and 50% track expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6733165_1738675035663.20250204_210942.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Beamanator]

Helping look into this one 🤚

[Beamanator]

Pretty sure this issue comes from #52061, but since this is a new feature, I'm 99% sure we can mark this NAB - confirming in slack before doing that

[luacmartins]

@FitseTLT @hoangzinh It seems like this came from our PR. @FitseTLT could you please look into this? We want to display the ... owes message in the LHN, instead of the tracking one.

[FitseTLT]

@FitseTLT @hoangzinh It seems like this came from our PR. @FitseTLT could you please look into this? We want to display the ... owes message in the LHN, instead of the tracking one.

OK on it

[Beamanator]

Marking NAB 👍 @luacmartins you wanna take over here? 🤷 i'm down to keep it, but happy to pass it to you!

[luacmartins]

Taking over

[FitseTLT]

@FitseTLT @hoangzinh It seems like this came from our PR. @FitseTLT could you please look into this? We want to display the ... owes message in the LHN, instead of the tracking one.

@luacmartins The tracking... LHN is being set from BE

2025-02-04.23-07-36.mp4

[luacmartins]

So it seems like the IOU action is still set to type = 'track', so we're fetching it here and we end up translating it here

[luacmartins]

@yuwenmemon @thienlnam do you know if we can update the IOU action to remove the type: 'track' once we call AddTrackedExpenseToPolicy or do we use that for some other tracking purpose?

[thienlnam]

IIRC, AddTrackedExpenseToPolicy is adding a non-reimbursable expense to a workspace so the type track is used to denote that

[luacmartins]

Hmm in this case we're actually passing reimbursable = true to the expense. Should we be changing the type then?

[thienlnam]

Ah given that we're overriding the reimbursable state then we should change the type based on that

[sakluger]

Just checking, what's the next step here?

[sakluger]

@luacmartins friendly bump, what's the next step on this GH issue?

[luacmartins]

I have this PR in review https://github.com/Expensify/Auth/pull/14118 that fixes the issue