-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging code to main can trigger deploy of unrelated systems #9725
Comments
Not a priority for now. |
Going to pick deploy improvements back up this week. Was holding off last week to avoid disrupting App deploys – we had some big checklists to get through |
Not going to address this just now. Switching to monthly |
Not a priority atm |
No update |
No update |
No update |
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
Taking this off HOLD and will address it after I come back from OOO to prevent HelpDot test builds on non-HelpDot PRs for the sake of noise reduction. |
This was addressed in #30315 |
Problem
We are working on releasing a new help site that's hosted in this repo. It deploys whenever code is merged to main. However, its deploy can be triggered even if the changes merged are completely unrelated to the help site, which causes:
Similarly, merging helpsite-related code can trigger deploys of the main NewDot platform, which causes all the same issues, except it's even worse / more noisy.
Why this is important
This wastes engineering and QA time, and may distract others as well.
Solution
Check if a PR only contains changes in the
/help
directory. If so:If not (changes include files not in the
/help
directory, don't deploy the helpsiteThe text was updated successfully, but these errors were encountered: