Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging code to main can trigger deploy of unrelated systems #9725

Closed
roryabraham opened this issue Jul 5, 2022 · 12 comments
Closed

Merging code to main can trigger deploy of unrelated systems #9725

roryabraham opened this issue Jul 5, 2022 · 12 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 NewFeature Something to build that is a new item. Not a priority

Comments

@roryabraham
Copy link
Contributor

Problem

We are working on releasing a new help site that's hosted in this repo. It deploys whenever code is merged to main. However, its deploy can be triggered even if the changes merged are completely unrelated to the help site, which causes:

  1. An unnecessary deploy
  2. Noise in slack
  3. Noise in the git history
  4. Unnecessary bloating of the deploy checklist

Similarly, merging helpsite-related code can trigger deploys of the main NewDot platform, which causes all the same issues, except it's even worse / more noisy.

Why this is important

This wastes engineering and QA time, and may distract others as well.

Solution

Check if a PR only contains changes in the /help directory. If so:

  1. Don't add the PR to the main NewDot deploy checklist
  2. Don't trigger a NewDot deploy, and instead only deploy the helpsite

If not (changes include files not in the /help directory, don't deploy the helpsite

@roryabraham roryabraham added Engineering Weekly KSv2 Improvement Item broken or needs improvement. labels Jul 5, 2022
@roryabraham roryabraham self-assigned this Jul 5, 2022
@melvin-bot melvin-bot bot added the Overdue label Jul 14, 2022
@roryabraham
Copy link
Contributor Author

Not a priority for now.

@roryabraham
Copy link
Contributor Author

Going to pick deploy improvements back up this week. Was holding off last week to avoid disrupting App deploys – we had some big checklists to get through

@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2022
@roryabraham
Copy link
Contributor Author

Not going to address this just now. Switching to monthly

@melvin-bot melvin-bot bot removed the Overdue label Aug 3, 2022
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Aug 3, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 5, 2022
@roryabraham
Copy link
Contributor Author

Not a priority atm

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 6, 2022
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@puneetlath puneetlath added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 2, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 8, 2022
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Nov 9, 2022
@roryabraham roryabraham changed the title Merging code to main can trigger deploy of unrelated systems [HOLD] Merging code to main can trigger deploy of unrelated systems Nov 28, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2022
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Dec 14, 2022
@roryabraham roryabraham removed their assignment Dec 14, 2022
@MelvinBot
Copy link

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed May 12, 2023
@roryabraham roryabraham reopened this Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Sep 22, 2023
@roryabraham roryabraham reopened this Sep 26, 2023
@roryabraham roryabraham self-assigned this Oct 5, 2023
@roryabraham roryabraham changed the title [HOLD] Merging code to main can trigger deploy of unrelated systems Merging code to main can trigger deploy of unrelated systems Oct 5, 2023
@roryabraham
Copy link
Contributor Author

Taking this off HOLD and will address it after I come back from OOO to prevent HelpDot test builds on non-HelpDot PRs for the sake of noise reduction.

@roryabraham
Copy link
Contributor Author

This was addressed in #30315

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 NewFeature Something to build that is a new item. Not a priority
Projects
None yet
Development

No branches or pull requests

3 participants