Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Expensify Help site design #12494

Merged
merged 7 commits into from
Nov 9, 2022
Merged

update Expensify Help site design #12494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b30a6b
change margin for body and title in card
marcochavezf Nov 5, 2022
347d2ac
set a specific margin for hub cards
marcochavezf Nov 5, 2022
504fbc2
change class and add it to concierge card
marcochavezf Nov 5, 2022
0cb32a0
add min-height in description hub cards
marcochavezf Nov 5, 2022
2c17cf0
update grid gaps
marcochavezf Nov 5, 2022
66282f5
update min-height description for mobile
marcochavezf Nov 5, 2022
9feb101
update margin to 4px
marcochavezf Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/_includes/hub-card.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
<img class="icon" src="{{ hub.icon }}" alt="{{ hub.href }}"/>
</div>
<div class="body">
<h3 class="title">{{ hub.title }}</h3>
<p class="description">{{ hub.description }}</p>
<h3 class="title with-margin">{{ hub.title }}</h3>
<p class="description with-min-height">{{ hub.description }}</p>
</div>
</div>
</a>
2 changes: 1 addition & 1 deletion docs/_layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ <h1 class="title">
<!-- Concierge button at the bottom of the page -->
<a class="card get-help" href="{{ CONCIERGE_CHAT_URL }}" target="_blank">
<div class="body">
<h3 class="title">Didn't find what you were looking for?</h3>
<h3 class="title with-margin">Didn't find what you were looking for?</h3>
<p class="description">Concierge is here to answer all your questions.</p>
</div>
<div class="submit-button">
Expand Down
22 changes: 18 additions & 4 deletions docs/_sass/_main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,12 +390,12 @@ button {
.cards-group {
display: grid;
grid-template-columns: auto;
row-gap: 12px;
column-gap: 4%;
row-gap: 20px;
column-gap: 20px;
padding-bottom: 20px;

@include breakpoint($breakpoint-desktop) {
grid-template-columns: 48% 48%;
grid-template-columns: auto auto;
}
}

Expand Down Expand Up @@ -456,12 +456,26 @@ button {
h3.title {
padding: 0;
margin: 0;

&.with-margin {
margin: 0 0 4px 0;
}
}



p.description {
padding: 0;
margin: 16px 0 0 0;
margin: 0;
font-weight: normal;

&.with-min-height {
min-height: 68px;

@include breakpoint($breakpoint-tablet) {
min-height: 48px;
}
}
}
}

Expand Down