Use measureLayout to calculate scrolling #13499

aldo-expensify · 2022-12-10T01:37:47Z

Details

Partially reverts Scroll to the right spot when clicking "Fix Errors" #12954
Use measureLayout to find out where to scroll to

Fixed Issues

$ #13401
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Login in New Dot
Go to Settings > Payments
Click "Add payment method" and select "Debit card"
Click "Save" without entering any data
Verify that all inputs have errors
if you are in web or desktop, resize the window enough to have scrolling in the RHN:
Scroll down and click "fix the errors"
Verify that the first input gets focused and you are scrolled until it is fully visible (including the top border)
Input something in the first input "Name on card"
Scroll down and click again "fix the errors"
Verify that the second input gets focused and you are scrolled until it is fully visible (including the top border)
Go back to the Settings > Payments page
Click "Add payment method" and select "Bank account"
Verify that the spinner is in the middle and not in the top

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Login in New Dot
Go to Settings > Payments
Click "Add payment method" and select "Debit card"
Click "Save" without entering any data
Verify that all inputs have errors
if you are in web or desktop, resize the window enough to have scrolling in the RHN:
Scroll down and click "fix the errors"
Verify that the first input gets focused and you are scrolled until it is fully visible (including the top border)
Input something in the first input "Name on card"
Scroll down and click again "fix the errors"
Verify that the second input gets focused and you are scrolled until it is fully visible (including the top border)
Go back to the Settings > Payments page
Click "Add payment method" and select "Bank account"
Verify that the spinner is in the middle and not in the top

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2022-12-09.at.5.48.52.PM.mov

Mobile Web - Chrome

Screen.Recording.2022-12-09.at.5.45.05.PM.mov

Mobile Web - Safari

Screen.Recording.2022-12-09.at.5.45.49.PM.mov

Desktop

Screen.Recording.2022-12-09.at.5.47.57.PM.mov

iOS

Screen.Recording.2022-12-09.at.5.39.40.PM.mov

Android

Screen.Recording.2022-12-09.at.5.40.45.PM.mov

melvin-bot · 2022-12-10T01:37:52Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

…ng-and-centering-regression

melvin-bot · 2022-12-10T01:57:37Z

@thesahindia @MonilBhavsar One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2022-12-10T01:58:04Z

cc @Gonals

thesahindia · 2022-12-12T10:37:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-12-12.at.3.54.58.PM.mov

Mobile Web - Chrome

Screen.Recording.2022-12-12.at.3.50.54.PM.mov

Mobile Web - Safari

Screen.Recording.2022-12-12.at.3.59.09.PM.mov

Desktop

Screen.Recording.2022-12-12.at.3.35.05.PM.mov

iOS

Screen.Recording.2022-12-12.at.3.57.59.PM.mov

Android

Screen.Recording.2022-12-12.at.3.46.29.PM.mov

thesahindia

Looks good and tests well!

C+ reviewed 🎀👀🎀

all yours @MonilBhavsar

MonilBhavsar

Looks good and works well

OSBotify · 2022-12-12T15:44:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-12-15T22:42:22Z

🚀 Deployed to production by @chiragsalian in version: 1.2.39-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aldo-expensify added 2 commits December 9, 2022 17:35

Use measureLayout to calculate scrolling

df32a98

Call measureLayout safely

f2ac03b

aldo-expensify self-assigned this Dec 10, 2022

aldo-expensify mentioned this pull request Dec 10, 2022

[HOLD for payment 2022-12-22] DEV - Loading indicator is not in center on Add Bank Account #13401

Closed

Merge branch 'main' of github.com:Expensify/App into aldo_fix-scrolli…

0c68fa6

…ng-and-centering-regression

aldo-expensify marked this pull request as ready for review December 10, 2022 01:57

aldo-expensify requested a review from a team as a code owner December 10, 2022 01:57

melvin-bot bot requested review from MonilBhavsar and thesahindia and removed request for a team December 10, 2022 01:57

aldo-expensify mentioned this pull request Dec 10, 2022

Scroll to the right spot when clicking "Fix Errors" #12954

Merged

98 tasks

thesahindia approved these changes Dec 12, 2022

View reviewed changes

MonilBhavsar approved these changes Dec 12, 2022

View reviewed changes

MonilBhavsar merged commit 7054f9c into main Dec 12, 2022

MonilBhavsar deleted the aldo_fix-scrolling-and-centering-regression branch December 12, 2022 15:39

chiragsalian mentioned this pull request Dec 14, 2022

Deploy Checklist: New Expensify 2022-12-13 #13577

Closed

13 tasks

aldo-expensify mentioned this pull request Jan 3, 2023

[$1000] Dev - Pressing on ‘fix the errors’ on validation forms throw error message #13909

Closed

6 tasks

aldo-expensify mentioned this pull request Jan 19, 2023

Fix: Scroll to picker regression #14409

Merged

54 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use measureLayout to calculate scrolling #13499

Use measureLayout to calculate scrolling #13499

aldo-expensify commented Dec 10, 2022 •

edited

Loading

melvin-bot bot commented Dec 10, 2022

melvin-bot bot commented Dec 10, 2022

aldo-expensify commented Dec 10, 2022

thesahindia commented Dec 12, 2022

thesahindia left a comment

MonilBhavsar left a comment

OSBotify commented Dec 12, 2022

OSBotify commented Dec 15, 2022

Use measureLayout to calculate scrolling #13499

Use measureLayout to calculate scrolling #13499

Conversation

aldo-expensify commented Dec 10, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 10, 2022

melvin-bot bot commented Dec 10, 2022

aldo-expensify commented Dec 10, 2022

thesahindia commented Dec 12, 2022

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

MonilBhavsar left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 12, 2022

OSBotify commented Dec 15, 2022

aldo-expensify commented Dec 10, 2022 •

edited

Loading