Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: iOS button obstructed by keyboard #14392

Merged
merged 2 commits into from
Jan 30, 2023
+9 −9
Merged

Fix: iOS button obstructed by keyboard #14392

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e170c69
Fix: iOS button obstructed by keyboard
rawalyogendra Jan 18, 2023
6a1ae16
Bump: @expensify/react-native-web to the latest version
rawalyogendra Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ScreenWrapper/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class ScreenWrapper extends React.Component {
paddingStyle,
]}
>
<KeyboardAvoidingView style={[styles.w100, styles.h100]} behavior={this.props.keyboardAvoidingViewBehavior}>
<KeyboardAvoidingView style={[styles.w100, styles.h100, {maxHeight: this.props.windowHeight}]} behavior={this.props.keyboardAvoidingViewBehavior}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawalyogendra I have a question about it. what is the reason maxHeight is set in KeyboardAvoidingView and not in the outermost View component? Do you think there will be a regression if we move the maxHeight to the outermost View component?

<HeaderGap />
{// If props.children is a function, call it to provide the insets to the children.
_.isFunction(this.props.children)
Expand Down