Create DeleteMoneyRequest command #17583

luacmartins · 2023-04-18T15:11:27Z

Details

Removes Cancel and Decline money request functionality in favor of Delete

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/270502

Tests

Pre-requisites: 2 accounts you have access to
Should be tested with the Web-E and Auth PRs

From account A, request money to account B + > Request money
From account A, tap the request and verify that you see the Delete option
From account B, tap the request and verify that you don't see the Delete option
From account A, tap Delete
Verify that the request is deleted (the preview is not shown anymore) and you see a deleted the $X request for comment message in chat and LHN
Verify that the report total is updated to $0

Verify that no errors appear in the JS console

Offline tests

From account A, request money to account B + > Request money
Go offline
From account A, tap Delete
Verify that the request is deleted (the preview is not shown anymore) and you see a deleted the $X request for comment message in chat and LHN, but the message is greyed out
Verify that the report total is updated to $0

QA Steps

Same as steps above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

…cline and cancel optimistic message

s77rt · 2023-05-03T20:30:49Z

@luacmartins

Verify that the request is deleted (the preview is not shown anymore) and you see a deleted the $X request for comment message in chat and LHN, but the message is greyed out

This is failing, the greyed out deleted message shows up but the preview is also still shown, maybe this is related to currency difference? (I will upload the videos asap)

Edit: I think it's indeed related to the diff in currency but I expected the preview to be at least greyed if currency is diff.

Edit2: I have added videos

on Web the currency is the same, the preview is hidden. ✔️
on mWeb the currency is diff, the preview is still shown and not greyed out. ❌

s77rt · 2023-05-03T21:25:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

mweb.mp4

Mobile Web - Safari

mweb.mp4

Desktop

desktop.mp4

iOS

Android

s77rt · 2023-05-03T21:33:40Z

I was not able to test this reliably on Native. Sometimes it works, sometimes it does not. I think this is not related to this PR but to the staging switch, it seems buggy.

getting jsonCode: 400 response

native-buggy.mp4

aldo-expensify · 2023-05-03T22:16:04Z

Conflicts 😬

luacmartins · 2023-05-04T08:04:47Z

Conflicts resolved!

luacmartins · 2023-05-04T08:06:23Z

@s77rt it's possible that there's something weird going on with the staging switch. Hopefully we'll get these changed in production today and we can test it in prod soon.

s77rt · 2023-05-04T09:28:39Z

@luacmartins Please address the buggy preview #17583 (comment)

luacmartins · 2023-05-04T16:20:53Z

@s77rt we are changing the behavior of the previews to always be shown, so they won't disappear anymore. I think it's fine to leave it as is

s77rt · 2023-05-04T16:27:55Z

@luacmartins Okay cool, so what's the next step here? We are basically done but I can't test on Native for the buggy staging switch. Should we wait till the PRs hit prod?

luacmartins · 2023-05-04T16:47:44Z

IMO we should just merge this given the urgency and address any issues as polish.

s77rt · 2023-05-04T17:05:02Z

I agree. The change is platform-independent anyway.

s77rt

LGTM! 🚀

MelvinBot · 2023-05-04T17:05:25Z

🎯 @s77rt, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #18421.

Comments addressed

Julesssss

Approving latest changes.

OSBotify · 2023-05-04T17:26:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-05T20:02:41Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-09T04:05:22Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shubham1206agra · 2024-01-23T15:13:31Z

src/libs/actions/IOU.js

                    errors: {
-                        [DateUtils.getMicroseconds()]: Localize.translateLocal('iou.error.genericCancelFailureMessage', {type}),
+                        [DateUtils.getMicroseconds()]: Localize.translateLocal('iou.error.genericDeleteFailureMessage'),


I think we forgot to put the error report preview action, which created the issue #33535

This is not a regression from this PR. We already added the report action in the optimistic data so we didn't need to add it in the failure data.

App/src/libs/actions/IOU.js

Lines 580 to 590 in 14ef884

const optimisticData = [

{

onyxMethod: CONST.ONYX.METHOD.MERGE,

key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReportID}`,

value: {

[optimisticReportAction.reportActionID]: {

...optimisticReportAction,

pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

},

},

},

luacmartins added 8 commits April 18, 2023 08:21

rename cancelMoneyRequest to deleteMoneyRequest

6077316

fix typo

37985d3

add system message for deleted request

7dc4e9a

rm type param, update logic in updateIOUOwnerAndTotal, change error copy

cd46125

rename debtor to payer

e69ab36

display delete button

37abc13

replace hardcoded values with consts

b9a55af

update logic for pending deleted request in different currency, rm de…

79922e5

…cline and cancel optimistic message

luacmartins self-assigned this Apr 18, 2023

rm request action and add rollback

8a8477e

luacmartins changed the title ~~Crete DeleteMoneyRequest command~~ Create DeleteMoneyRequest command Apr 18, 2023

luacmartins added 13 commits April 18, 2023 09:59

revert update amount logic

5650b4a

update comments

bf7b439

fix test

2025bcc

update comments

e475190

update comment

d3d9816

optimistically rm transaction from onyx

6ff57d3

add failure data

18c7b29

update var declaration

1562b43

update api params

b62b3ac

return early if transaction is null

c789367

leave created iou action

0459471

hide delete button for deleted request

852a080

lower case iou messages

30028e8

luacmartins marked this pull request as ready for review April 21, 2023 16:58

luacmartins requested a review from a team as a code owner April 21, 2023 16:58

luacmartins requested review from mountiny and Julesssss April 21, 2023 16:58

melvin-bot bot requested review from s77rt and removed request for a team April 21, 2023 16:58

resolve conflicts

14ef884

luacmartins dismissed stale reviews from Julesssss and mountiny via 14ef884 May 4, 2023 08:00

s77rt approved these changes May 4, 2023

View reviewed changes

melvin-bot bot mentioned this pull request May 4, 2023

Payment issue for E/App PR#17583 #18421

Closed

Julesssss approved these changes May 4, 2023

View reviewed changes

Julesssss merged commit 530e2f8 into main May 4, 2023

Julesssss deleted the cmartins-deleteMoneyRequest branch May 4, 2023 17:21

OSBotify mentioned this pull request May 5, 2023

Deploy Checklist: New Expensify 2023-05-05 #18498

Closed

31 tasks

Natnael-Guchima mentioned this pull request May 6, 2023

IOU - No "Decline" button appears next to each of the report requests #18527

Closed

6 tasks

Natnael-Guchima mentioned this pull request May 10, 2023

[$1000] A failed IOU request has the “Cancel” feature as a successful IOU request and able to cancel the request #16748

Closed

6 tasks

s77rt mentioned this pull request May 13, 2023

Use IOU/Expense reportID for IOU actions #18604

Merged

56 tasks

shubham1206agra reviewed Jan 23, 2024

View reviewed changes

shubham1206agra mentioned this pull request Jan 23, 2024

[HOLD for payment 2024-01-17] [$500] LHN - Red dot does not appear in LHN conversation when IOU deletion error occurs #33535

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create DeleteMoneyRequest command #17583

Create DeleteMoneyRequest command #17583

luacmartins commented Apr 18, 2023 •

edited

Loading

s77rt commented May 3, 2023 •

edited

Loading

s77rt commented May 3, 2023 •

edited

Loading

s77rt commented May 3, 2023

aldo-expensify commented May 3, 2023

luacmartins commented May 4, 2023

luacmartins commented May 4, 2023

s77rt commented May 4, 2023

luacmartins commented May 4, 2023

s77rt commented May 4, 2023

luacmartins commented May 4, 2023

s77rt commented May 4, 2023

s77rt left a comment

MelvinBot commented May 4, 2023

Julesssss left a comment

OSBotify commented May 4, 2023

OSBotify commented May 5, 2023

OSBotify commented May 9, 2023

shubham1206agra Jan 23, 2024

s77rt Jan 24, 2024

	const optimisticData = [
	{
	onyxMethod: CONST.ONYX.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReportID}`,
	value: {
	[optimisticReportAction.reportActionID]: {
	...optimisticReportAction,
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},
	},
	},

Create DeleteMoneyRequest command #17583

Create DeleteMoneyRequest command #17583

Conversation

luacmartins commented Apr 18, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

s77rt commented May 3, 2023 • edited Loading

s77rt commented May 3, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented May 3, 2023

aldo-expensify commented May 3, 2023

luacmartins commented May 4, 2023

luacmartins commented May 4, 2023

s77rt commented May 4, 2023

luacmartins commented May 4, 2023

s77rt commented May 4, 2023

luacmartins commented May 4, 2023

s77rt commented May 4, 2023

s77rt left a comment

Choose a reason for hiding this comment

MelvinBot commented May 4, 2023

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented May 4, 2023

OSBotify commented May 5, 2023

OSBotify commented May 9, 2023

shubham1206agra Jan 23, 2024

Choose a reason for hiding this comment

s77rt Jan 24, 2024

Choose a reason for hiding this comment

luacmartins commented Apr 18, 2023 •

edited

Loading

s77rt commented May 3, 2023 •

edited

Loading

s77rt commented May 3, 2023 •

edited

Loading