-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate index.native.js to function component #24615
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
2a543a2
Updated variables and states (WIP)
kadiealexander 0b36d7c
began updating lifecycle method to useEffect
kadiealexander 3dcc675
Merge branch 'main' of github.com:Expensify/App into kadie-native-ind…
kadiealexander 3834c8c
latest useEffect updates
kadiealexander 67b1555
merge main
kadiealexander aa23f3a
Merge branch 'main' into kadie-native-index-update
kadiealexander 00efb24
small errors found during testing
kadiealexander 520b39d
trying to make lint happy
kadiealexander 72f601d
Revert "small errors found during testing"
kadiealexander 437ebeb
Revert "small errors found during testing"
kadiealexander 3597be6
fix functions and run lint/prettier
kadiealexander 6f892b6
merging with main
kadiealexander bffa142
Merge branch 'main' of github.com:Expensify/App into kadie-native-ind…
kadiealexander b010ede
ran prettier
kadiealexander c15f3d4
removed unnecessary PasswordResponses definition
kadiealexander 968be38
merge main
kadiealexander cc5e2de
destructured props
kadiealexander 8b5081d
destructured props
kadiealexander f842efc
updated arrow functions per comment
kadiealexander 76c508e
updated arrow function for onSubmit per comment
kadiealexander e527f41
updated arrow function for onPasswordUpdated due to incorrect change
kadiealexander 6bcfcdb
merging main and resolving conflicts
kadiealexander 71d12f1
Merge branch 'main' of github.com:Expensify/App into kadie-native-ind…
kadiealexander 7d8fbbe
merge with main and addressed reviewer comments
kadiealexander ee78ab6
fix lint issue
kadiealexander 371b846
fix hook issue with previous commit
kadiealexander 203e2ba
Update index.native.js
kadiealexander d20986f
Update index.native.js
kadiealexander 29175df
Merge branch 'main' into kadie-native-index-update
kadiealexander 0b0ed8c
fix lint error
kadiealexander 9b4cf2e
fix lint error
kadiealexander 9c38ea8
merging main
kadiealexander b42a4b2
fixing weird lint error
kadiealexander c9e5397
fixing lint error
kadiealexander 4c08eb6
Update src/components/PDFView/index.native.js
kadiealexander 798861b
merging main
kadiealexander 347c1f5
Update src/components/PDFView/index.native.js
kadiealexander a74f76b
running prettier
kadiealexander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please undo this line break removal