fix image reload on session change #26365

b4s36t4 · 2023-08-31T03:56:00Z

Details

Fixes image reload on session change while disabling the 2FA.

Fixed Issues

$ #26034
PROPOSAL: #26034 (comment)

Tests

Verify that no errors appear in the JS console

Before hand send some images to any report and keep it in the backgroun.
Go to security -> Complete whole 2FA.
Once 2FA is completed, you'll have to click the Disable 2FA
Observe that no images re-load.

Offline tests

NA - 2FA won't work on offline.

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Kapture.2023-08-31.at.12.49.50.mp4

Mobile Web - Chrome

video_2023-09-01_10-49-00.mp4

Mobile Web - Safari

Kapture.2023-08-31.at.17.59.44.mp4

Desktop

Kapture.2023-08-31.at.12.58.54.mp4

iOS

Kapture.2023-08-31.at.17.41.55.mp4

Android

video_2023-09-01_10-49-08.1.mp4

b4s36t4 · 2023-08-31T07:20:37Z

@cubuspl42 I'm wondering weather to attach the screen recordings for mobile devices?

b4s36t4 · 2023-08-31T07:21:46Z

in mobile devices we have to move back to main page then settings and then all this process is there, and to observe the reload we have to go again with the same flow once again reverse. This doesn't seem a valid case for me.

b4s36t4 · 2023-08-31T07:30:53Z

Added screen recordings for web and desktop.

melvin-bot · 2023-08-31T07:34:39Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2023-08-31T08:27:46Z

src/components/Image/index.js

@@ -22,7 +22,9 @@ function Image(props) {
            return {uri: `${propsSource.uri}?encryptedAuthToken=${encodeURIComponent(authToken)}`};
        }
        return propsSource;
-    }, [propsSource, isAuthTokenRequired, session]);
+
+        // eslint-disable-next-line react-hooks/exhaustive-deps


We definitely need a comment explaining why we disable the warning

Will update.

// The `session` prop is not necessary, as it triggers image reloading whenever the session changes. Refer to issue #26034 for more details.

Method I used: GP4 + "Could you make this comment more proper English?"

@cubuspl42 Updated the comment.

cubuspl42 · 2023-08-31T08:30:11Z

in mobile devices we have to move back to main page then settings and then all this process is there, and to observe the reload we have to go again with the same flow once again reverse. This doesn't seem a valid case for me.

So what you're saying is that on iOS/Android (Native?) before the fix it was difficult to observe the bug, but now it's impossible? Or that the fix didn't work all on some platforms?

cubuspl42 · 2023-08-31T08:32:23Z

I'm wondering weather to attach the screen recordings for mobile devices?

Yes, it's important to test on all platforms, even when we just confirm that the modified component still works as expected. There always might be some surprising behavior both on Native (which is much different on the technical level) and from mobile browsers quirks.

b4s36t4 · 2023-08-31T08:57:16Z

#26365 (comment)

What I'm saying is even if try the same flow, it would be same behaviour because once we disable the 2FA we have to go the screen again by navigation which causes image to re-render whereas in browser we can observe this because the report is in background itself, understood?

b4s36t4 · 2023-08-31T12:36:11Z

@cubuspl42 I have updated the screenrecording for ios devices. You can start your review by then I'll update the android screen-recordings.

b4s36t4 · 2023-09-01T05:25:02Z

@cubuspl42 I have completed all the changes you requested and also added screen recordings for other platforms too.

cubuspl42 · 2023-09-01T18:59:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

2fa-image-reload-web.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-01T20:31:09Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2023-09-01T20:36:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-01T23:37:08Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.3.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny · 2023-09-03T18:49:41Z

@kavimuru you have mentioned in here the PR fails the QA of the linked issue, but I dont see any comment here or on the issue. Maybe its too early but could you please leave video/ note here of this being not fixed?

OSBotify · 2023-09-04T16:21:50Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

b4s36t4 mentioned this pull request Aug 31, 2023

[HOLD for payment 2023-09-11] [$1000] Images blinks on click on Got it button #26034

Closed

6 tasks

b4s36t4 marked this pull request as ready for review August 31, 2023 07:34

b4s36t4 requested a review from a team as a code owner August 31, 2023 07:34

melvin-bot bot requested review from cubuspl42 and removed request for a team August 31, 2023 07:34

cubuspl42 reviewed Aug 31, 2023

View reviewed changes

b4s36t4 force-pushed the fix/image-reload-on-session-change branch from 2b43ebb to bb85ebf Compare September 1, 2023 13:26

update comment

bf4a775

b4s36t4 force-pushed the fix/image-reload-on-session-change branch from bb85ebf to bf4a775 Compare September 1, 2023 13:28

cubuspl42 approved these changes Sep 1, 2023

View reviewed changes

melvin-bot bot requested a review from yuwenmemon September 1, 2023 19:00

yuwenmemon approved these changes Sep 1, 2023

View reviewed changes

yuwenmemon merged commit 918eae2 into Expensify:main Sep 1, 2023

b4s36t4 deleted the fix/image-reload-on-session-change branch September 1, 2023 20:41

OSBotify mentioned this pull request Sep 1, 2023

Deploy Checklist: New Expensify 2023-09-01 #26539

Closed

40 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix image reload on session change #26365

fix image reload on session change #26365

b4s36t4 commented Aug 31, 2023 •

edited

Loading

b4s36t4 commented Aug 31, 2023

b4s36t4 commented Aug 31, 2023

b4s36t4 commented Aug 31, 2023

melvin-bot bot commented Aug 31, 2023

cubuspl42 Aug 31, 2023

b4s36t4 Aug 31, 2023

cubuspl42 Sep 1, 2023

b4s36t4 Sep 1, 2023

cubuspl42 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

b4s36t4 commented Aug 31, 2023

b4s36t4 commented Aug 31, 2023

b4s36t4 commented Sep 1, 2023

cubuspl42 commented Sep 1, 2023

melvin-bot bot commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

mountiny commented Sep 3, 2023

OSBotify commented Sep 4, 2023

fix image reload on session change #26365

fix image reload on session change #26365

Conversation

b4s36t4 commented Aug 31, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

b4s36t4 commented Aug 31, 2023

b4s36t4 commented Aug 31, 2023

b4s36t4 commented Aug 31, 2023

melvin-bot bot commented Aug 31, 2023

cubuspl42 Aug 31, 2023

Choose a reason for hiding this comment

b4s36t4 Aug 31, 2023

Choose a reason for hiding this comment

cubuspl42 Sep 1, 2023

Choose a reason for hiding this comment

b4s36t4 Sep 1, 2023

Choose a reason for hiding this comment

cubuspl42 commented Aug 31, 2023

cubuspl42 commented Aug 31, 2023

b4s36t4 commented Aug 31, 2023

b4s36t4 commented Aug 31, 2023

b4s36t4 commented Sep 1, 2023

cubuspl42 commented Sep 1, 2023

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

mountiny commented Sep 3, 2023

OSBotify commented Sep 4, 2023

b4s36t4 commented Aug 31, 2023 •

edited

Loading