Fix overlay size #26385

adamgrzybowski · 2023-08-31T11:54:20Z

Details

I've changed the size of the overlay to offset the translate animation.

Fixed Issues

https://swmansion.slack.com/archives/C04878MDF34/p1693469210575919

$ #26390
PROPOSAL:

Tests

Open the RHP
Verify you cannot see the overlay fading in/ animating
Verify the page itself si not scrollable horizontally

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

androidWeb.mov

Mobile Web - Safari

iosWeb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-08-31T11:54:57Z

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-08-31T12:31:00Z

yo

allroundexperts · 2023-08-31T12:31:00Z

I can review!

allroundexperts · 2023-08-31T12:31:27Z

All yours @rushatgabhane!

rushatgabhane · 2023-08-31T12:46:09Z

src/styles/styles.js

@@ -1514,7 +1513,13 @@ const styles = {
    },

    overlayStyles: (current) => ({
-        ...StyleSheet.absoluteFillObject,
+        position: 'fixed',


Does this work on iPad? If i'm not wrong, position type fixed doesn't work in react native.

Yeah, but the overlay is visible only for wide view and that's something we don't support yet on iOS and Android.

ios safari with ipad on landscape?

could we think of some alternative solution that will work on landscape iPad?
I know that we don't support it yet, but I'd prefer to solve this problem for all platforms.

What do you think?

By iOS and Android, I meant the native apps. It will work on safari/chrome mobile.

We could think about alternative solutions but supporting three pane view in native apps requires more changes anyway. I am not sure if it's worth doing now if the code can change.

@rushatgabhane I think it does not work at all in native ipad now so we should not spend time on it now, but I agree that making it work in ipad landscape should be on our list soon

mountiny · 2023-08-31T15:28:07Z

@adamgrzybowski can you also look into this tint issue #26405 in this pr?

neil-marcellini · 2023-08-31T17:27:15Z

@mountiny is it ok with you if I remove my request for review? I don't really have context on this.

mountiny · 2023-08-31T17:58:34Z

@neil-marcellini absolutely fine

adamgrzybowski · 2023-09-01T12:17:24Z

@adamgrzybowski can you also look into this tint issue #26405 in this pr?

So I used the themeColors.overlay that I found. It's possible that when we started the initial navigation refactor we accidentally changed it to black.

I can change it, but I think it's worth checking the designs or something what the color really should be.

@mountiny Let me know what you think!

mountiny · 2023-09-01T15:03:20Z

@adamgrzybowski @rushatgabhane can you please provide screenshots/ video in the PR and checklist

@shawnborton could you please give this one a look and confirm the overlay looks good, once Adam will upload the video or you can run it locally too

shawnborton · 2023-09-01T16:19:38Z

Sounds good, will wait for videos.

adamgrzybowski · 2023-09-01T16:24:11Z

Videos updated in the description

shawnborton · 2023-09-01T17:01:50Z

Nice, that feels good to me!

mountiny

@rushatgabhane All yours Shawn has approved, thanks!

I believe this is low risk PR but good design fix so we should not hold this one

rushatgabhane · 2023-09-02T02:18:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-05.at.12.48.53.mov

Mobile Web - Chrome

Screen.Recording.2023-09-05.at.13.10.36.mov

Mobile Web - Safari

Screen.Recording.2023-09-05.at.13.01.58.mov

Desktop

Screen.Recording.2023-09-05.at.13.00.04.mov

iOS

Screen.Recording.2023-09-05.at.12.55.58.mov

Android

Screen.Recording.2023-09-05.at.13.07.13.mov

rushatgabhane · 2023-09-05T07:42:50Z

@mountiny good to merge!

mountiny · 2023-09-12T10:13:05Z

@rushatgabhane Wojti has synced with main, any chance you could give this a quick retest before merging? thanks!

rushatgabhane · 2023-09-12T10:32:43Z

sure, I can re-test once i reach home (3 hrs)

mountiny · 2023-09-12T10:41:11Z

amazing, thanks!

rushatgabhane · 2023-09-12T14:34:19Z

@mountiny LGTM

Screen.Recording.2023-09-12.at.20.03.09.mov

mountiny · 2023-09-13T05:59:21Z

Thanks!

OSBotify · 2023-09-13T06:04:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-13T09:12:56Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.69-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-14T10:27:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.69-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-14T10:53:58Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-18T10:11:57Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

s77rt · 2023-09-29T19:36:37Z

src/styles/styles.js

@@ -1520,8 +1519,14 @@ const styles = {
    },

    overlayStyles: (current) => ({
-        ...StyleSheet.absoluteFillObject,
-        backgroundColor: themeColors.overlay,


This caused a regression #27353. The background color should have kept as overlay.

fix overlay

3b7204a

adamgrzybowski requested a review from a team as a code owner August 31, 2023 11:54

melvin-bot bot requested review from neil-marcellini and removed request for a team August 31, 2023 11:54

mountiny assigned adamgrzybowski Aug 31, 2023

mountiny requested a review from a team August 31, 2023 12:30

mountiny requested review from rushatgabhane and mountiny and removed request for a team August 31, 2023 12:31

rushatgabhane reviewed Aug 31, 2023

View reviewed changes

mountiny requested a review from shawnborton September 1, 2023 15:02

change overlay color to black

41e597b

mountiny approved these changes Sep 1, 2023

View reviewed changes

neil-marcellini removed their request for review September 1, 2023 21:38

rushatgabhane approved these changes Sep 5, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny September 5, 2023 07:42

mountiny changed the title ~~Fix overlay size~~ [hold freeze] Fix overlay size Sep 5, 2023

laurenreidexpensify mentioned this pull request Sep 7, 2023

[HOLD for payment 2023-09-21] Overlay when RHP is opening is not over the entire page #26390

Closed

mountiny changed the title ~~[hold freeze] Fix overlay size~~ Fix overlay size Sep 12, 2023

Merge branch 'main' into @swm/fix-overlay

a7816fd

mountiny merged commit a29fac2 into Expensify:main Sep 13, 2023
10 checks passed

OSBotify mentioned this pull request Sep 13, 2023

Deploy Checklist: New Expensify 2023-09-13 #27313

Closed

72 tasks

s-alves10 mentioned this pull request Sep 13, 2023

[HOLD for payment 2023-10-05] [$500] Web - Overlay background colour is different #27353

Closed

6 tasks

OSBotify mentioned this pull request Sep 14, 2023

Deploy Checklist: New Expensify 2023-09-14 #27425

Closed

s77rt reviewed Sep 29, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix overlay size #26385

Fix overlay size #26385

adamgrzybowski commented Aug 31, 2023 •

edited

Loading

melvin-bot bot commented Aug 31, 2023

rushatgabhane commented Aug 31, 2023

allroundexperts commented Aug 31, 2023 •

edited

Loading

allroundexperts commented Aug 31, 2023

rushatgabhane Aug 31, 2023 •

edited

Loading

adamgrzybowski Aug 31, 2023

mountiny Aug 31, 2023

rushatgabhane Sep 1, 2023 •

edited

Loading

adamgrzybowski Sep 1, 2023

mountiny Sep 1, 2023

mountiny commented Aug 31, 2023

neil-marcellini commented Aug 31, 2023

mountiny commented Aug 31, 2023

adamgrzybowski commented Sep 1, 2023

mountiny commented Sep 1, 2023

shawnborton commented Sep 1, 2023

adamgrzybowski commented Sep 1, 2023

shawnborton commented Sep 1, 2023

mountiny left a comment

rushatgabhane commented Sep 2, 2023 •

edited

Loading

rushatgabhane commented Sep 5, 2023

mountiny commented Sep 12, 2023

rushatgabhane commented Sep 12, 2023

mountiny commented Sep 12, 2023

rushatgabhane commented Sep 12, 2023

mountiny commented Sep 13, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

s77rt Sep 29, 2023

Fix overlay size #26385

Fix overlay size #26385

Conversation

adamgrzybowski commented Aug 31, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 31, 2023

rushatgabhane commented Aug 31, 2023

allroundexperts commented Aug 31, 2023 • edited Loading

allroundexperts commented Aug 31, 2023

rushatgabhane Aug 31, 2023 • edited Loading

Choose a reason for hiding this comment

adamgrzybowski Aug 31, 2023

Choose a reason for hiding this comment

mountiny Aug 31, 2023

Choose a reason for hiding this comment

rushatgabhane Sep 1, 2023 • edited Loading

Choose a reason for hiding this comment

adamgrzybowski Sep 1, 2023

Choose a reason for hiding this comment

mountiny Sep 1, 2023

Choose a reason for hiding this comment

mountiny commented Aug 31, 2023

neil-marcellini commented Aug 31, 2023

mountiny commented Aug 31, 2023

adamgrzybowski commented Sep 1, 2023

mountiny commented Sep 1, 2023

shawnborton commented Sep 1, 2023

adamgrzybowski commented Sep 1, 2023

shawnborton commented Sep 1, 2023

mountiny left a comment

Choose a reason for hiding this comment

rushatgabhane commented Sep 2, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented Sep 5, 2023

mountiny commented Sep 12, 2023

rushatgabhane commented Sep 12, 2023

mountiny commented Sep 12, 2023

rushatgabhane commented Sep 12, 2023

mountiny commented Sep 13, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 13, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 14, 2023

OSBotify commented Sep 18, 2023

s77rt Sep 29, 2023

Choose a reason for hiding this comment

adamgrzybowski commented Aug 31, 2023 •

edited

Loading

allroundexperts commented Aug 31, 2023 •

edited

Loading

rushatgabhane Aug 31, 2023 •

edited

Loading

rushatgabhane Sep 1, 2023 •

edited

Loading

rushatgabhane commented Sep 2, 2023 •

edited

Loading