-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image loads on resize window #26543
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
73be910
Fix image loads on reesize window
tamdao 74a2652
Add prop types into AttachmentCarouselCellRenderer component
tamdao bcc644c
fix eslint warning
tamdao e15c420
remove unused func
tamdao e33802f
Merge branch 'main' into 26071-image-load
tamdao 48bc103
Merge branch 'main' into 26071-image-load
tamdao fd9e0ef
Merge branch 'main' into 26071-image-load
tamdao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
src/components/Attachments/AttachmentCarousel/AttachmentCarouselCellRenderer.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import React from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import {View, PixelRatio} from 'react-native'; | ||
import useWindowDimensions from '../../../hooks/useWindowDimensions'; | ||
import styles from '../../../styles/styles'; | ||
|
||
const propTypes = { | ||
/** Cell Container styles */ | ||
style: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]), | ||
}; | ||
|
||
const defaultProps = { | ||
style: [], | ||
}; | ||
|
||
function AttachmentCarouselCellRenderer(props) { | ||
const {windowWidth, isSmallScreenWidth} = useWindowDimensions(); | ||
const modalStyles = styles.centeredModalStyles(isSmallScreenWidth, true); | ||
const style = [props.style, styles.h100, {width: PixelRatio.roundToNearestPixel(windowWidth - (modalStyles.marginHorizontal + modalStyles.borderWidth) * 2)}]; | ||
|
||
return ( | ||
<View | ||
// eslint-disable-next-line react/jsx-props-no-spreading | ||
{...props} | ||
style={style} | ||
/> | ||
); | ||
} | ||
|
||
AttachmentCarouselCellRenderer.propTypes = propTypes; | ||
AttachmentCarouselCellRenderer.defaultProps = defaultProps; | ||
AttachmentCarouselCellRenderer.displayName = 'AttachmentCarouselCellRenderer'; | ||
|
||
export default React.memo(AttachmentCarouselCellRenderer); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from #28698.
We still want the position of the emoji modal to change instantly based on window size when toggling show/hide, so we switched it to
useWindowDimensions
without debounce. : )