-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/26888: New design when adding stop waypoint #27657
Conversation
Not sure how this got assigned to me. I'm adding @thienlnam & @0xmiroslav since they are the CME & C+ for the related GH. |
@0xmiroslav Bump |
This comment was marked as resolved.
This comment was marked as resolved.
There will be migration issue from old users.
Screen.Recording.2023-09-20.at.5.57.37.PM.movI hope this would be fine as all waypoints will be cleared in next request and this actually doesn't affect users. |
App crashes on latest main. Regression from #27729. Screen.Recording.2023-09-20.at.6.13.48.PM.mov |
@DylanDylann invalid waypoints still remaining in Onyx. Screen.Recording.2023-09-20.at.6.26.37.PM.mov |
@DylanDylann Let's address #27657 (comment) and #27657 (comment). |
Co-authored-by: 0xmiroslav <[email protected]>
@0xmiroslav thanks for this comment, why do you think it is a bug? And I see it isn't related to this PR. I am not sure but I remember that we had this bug before. If we decide to fix it on this PR we need to confirm if it is bug first to avoid regression |
Co-authored-by: 0xmiroslav <[email protected]>
Thanks for lint fixing |
@DylanDylann you know this was OP before requirement change? |
We can wait for @thienlnam's feedback |
@0xmiroslav Sorry, I miss it. I agree that we should disable next button if there is any empty waypoint. My suggestion is that we will disable next button if there is any empty waypoint |
Disabling button makes sense to me because |
@0xmiroslav Could you help to check last commit with the logic to disable button if there is any empty waypoint |
@0xmiroslav I updated, help to check again |
@0xmiroslav Updated. |
IMO, we should keep current button disable logic (don't disable even if invalid waypoints exist) So 2 options:
cc: @thienlnam |
We have another issue that addresses the handling for invalid waypoints - so we can just
|
Thanks @DylanDylann let's just revert button disable logic. And then we're good to go |
@0xmiroslav I reverted |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromemchrome.movMobile Web - Safarimsafari.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.73-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.74-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀
|
Details
When users click Add Stop, we will redirect them to waypoint editor immediately
Fixed Issues
$ #26888
PROPOSAL: #26888 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen-Recording-2023-09-18-at-17.57.06.mp4
Mobile Web - Chrome
Screen-Recording-2023-09-18-at-18.05.36.mp4
Mobile Web - Safari
Screen-Recording-2023-09-18-at-18.00.16.mp4
Desktop
Screen-Recording-2023-09-18-at-18.14.04.mp4
iOS
Screen-Recording-2023-09-18-at-18.35.43.mp4
Android
Screen-Recording-2023-09-18-at-23.26.59.mp4