-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create different files for HTML Render and fix scroll width #27769
Conversation
@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeandroid-web.movMobile Web - Safariios-web.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎀 👀 🎀 C+ reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more potential blocker
@jeet-dhandha can you check this one #27777 - will be nice to get fix in current opened PR |
Checking @narefyev91 |
Yes @narefyev91 caused due to this, as maximum 2 lines should only be rendered for Assign Task and we didn't think this one through. |
Do you have any suggestions on how we can handle trailing in |
@jeet-dhandha https://meliorence.github.io/react-native-render-html/api/renderhtmlprops#defaulttextprops - can be used. Or you can write a specific renderer - for only description - which will be re-used - like this one src/components/HTMLEngineProvider/HTMLRenderers/EditedRenderer.js |
Let me check that |
Fixed the overflow issue @narefyev91 @thienlnam. |
Handled #27777. |
Screenshots/VideosWebweb.movMobile Web - Chromemobile-chrome.movMobile Web - Safarimobile-safari.movDesktopdesktop.moviOSiOS.movAndroidandroid.mov |
Updated Videos for Overflow issue |
@jeet-dhandha based on conversation here https://expensify.slack.com/archives/C01GTK53T8Q/p1695182982405449 - we should show full description - instead of cutting it. Seems we need to just allow scrolling - instead of set max height |
Yes but if we set scroll on full |
Fixed:
694989f9-abaf-4bdf-a728-d8ee30fa8828.mp4 |
@jeet-dhandha are you plan to also include fix for this one #27812 ? |
Nope @narefyev91 , we can take up proposals on that one, after merging this PR. As its more of a feature request. |
@jeet-dhandha button on confirm task screen now not fixed in the bottom |
I wrapped the submit button in scrollview thats why. Quick question:
|
Reviewer Checklist
Screenshots/VideosWeb8mb.video-V0q-lHHCgUXh.mp4Mobile Web - Chrome8mb.video-YAK-U35lljfC.mp4Mobile Web - Safari8mb.video-EsE-njCuenYy.mp4Desktop8mb.video-1mX-5dMpekDW.mp4iOSios.movAndroid8mb.video-5xg-q7wMUgI0.mp4 |
All issues which were linked to this PR - fixed |
Screenshots/Videos (Confirm Task - Button Fix)Webscroll-web.mp4Mobile Web - Chromescroll-mobile-chrome.mp4Mobile Web - Safariscroll-mobile-safari.mp4Desktopscroll-desktop.mp4iOSscroll-iOS.mp4Androidscroll-android.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎀 👀 🎀 C+ reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for doing this!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.73-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.74-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀
|
@burczu mentioned that this issue and this issue might be regressions from this PR. @jeet-dhandha can you take a look and fix? |
Details
Follow Up Changes
MenuItemRenderHTMLTitle
for Rendering HTML based on platforms.Fixed Issues
$ #27722
$ #27777
$ #27802
$ #27881
PROPOSAL: #27722 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android